Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1003)

Issue 99160043: code review 99160043: go.blog: use the right declaration for Go's main function (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years ago by r
Modified:
10 years ago
Reviewers:
rh
CC:
golang-codereviews, rh
Visibility:
Public.

Description

go.blog: use the right declaration for Go's main function OMG department. Thanks to an anonymous correspondent for pointing it out. Why did no one notice this? The original translation here is lexically similar but very wrong. I had C on the brain when I wrote it. That doesn't happen so much any more.

Patch Set 1 #

Patch Set 2 : diff -r bfa8608b2028 https://code.google.com/p/go.blog #

Patch Set 3 : diff -r bfa8608b2028 https://code.google.com/p/go.blog #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M content/gos-declaration-syntax.article View 1 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 5
r
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go.blog
10 years ago (2014-05-10 21:43:44 UTC) #1
rh
On 2014/05/10 21:43:44, r wrote: > Hello mailto:golang-codereviews@googlegroups.com, > > I'd like you to review ...
10 years ago (2014-05-10 22:47:18 UTC) #2
r
Hello golang-codereviews@googlegroups.com, robert.hencke@gmail.com (cc: golang-codereviews@googlegroups.com), Please take another look.
10 years ago (2014-05-10 22:49:10 UTC) #3
rh
On 2014/05/10 22:49:10, r wrote: > Hello mailto:golang-codereviews@googlegroups.com, mailto:robert.hencke@gmail.com (cc: > mailto:golang-codereviews@googlegroups.com), > > Please ...
10 years ago (2014-05-10 22:50:17 UTC) #4
r
10 years ago (2014-05-11 10:59:49 UTC) #5
*** Submitted as
https://code.google.com/p/go/source/detail?r=807154aed299&repo=blog ***

go.blog: use the right declaration for Go's main function

OMG department.
Thanks to an anonymous correspondent for pointing it out.
Why did no one notice this?

The original translation here is lexically similar but very wrong.
I had C on the brain when I wrote it. That doesn't happen so much
any more.

LGTM=robert.hencke
R=golang-codereviews, robert.hencke
CC=golang-codereviews
https://codereview.appspot.com/99160043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b