Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(16)

Issue 9915045: code review 9915045: testing: round down to nearest power of 10 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 11 months ago by kr
Modified:
10 years, 11 months ago
Reviewers:
dave, golang-dev
Visibility:
Public.

Description

testing: round down to nearest power of 10 Fixes issue 5599

Patch Set 1 #

Patch Set 2 : diff -r 2f00f3e66cac https://code.google.com/p/go #

Patch Set 3 : diff -r 2f00f3e66cac https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -7 lines) Patch
M src/pkg/testing/benchmark.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/testing/benchmark_test.go View 1 1 chunk +9 lines, -6 lines 0 comments Download

Messages

Total messages: 8
kr
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
10 years, 11 months ago (2013-06-01 00:47:57 UTC) #1
dave_cheney.net
On 2013/06/01 00:47:57, kr wrote: > Hello mailto:golang-dev@googlegroups.com, > > I'd like you to review ...
10 years, 11 months ago (2013-06-01 00:59:20 UTC) #2
kr
Oops, I missed that. Will do.
10 years, 11 months ago (2013-06-01 01:34:18 UTC) #3
kr
Why not just apply https://codereview.appspot.com/9926043?
10 years, 11 months ago (2013-06-01 01:42:03 UTC) #4
dave_cheney.net
On 2013/06/01 01:42:03, kr wrote: > Why not just apply https://codereview.appspot.com/9926043? If you're happy with ...
10 years, 11 months ago (2013-06-01 01:44:35 UTC) #5
kr
Yeah I'm happy.
10 years, 11 months ago (2013-06-01 01:49:29 UTC) #6
kr
Abandoned.
10 years, 11 months ago (2013-06-01 01:50:14 UTC) #7
dave_cheney.net
10 years, 11 months ago (2013-06-01 01:51:04 UTC) #8
Ok, i'll mail mine out. There is some disparity in the test data we're
using, but we can talk about that on 9926043

On Sat, Jun 1, 2013 at 11:49 AM,  <kr@xph.us> wrote:
> Yeah I'm happy.
>
> https://codereview.appspot.com/9915045/
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b