code review 99040045: go-tour: add missing delete/error/rune predeclared iden...

go-tour: add missing delete/error/rune predeclared identifier for Syntax-Highlighting

[chai2010, 2014-05-14 01:33:46]

Hello golang-codereviews@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go-tour

[bradfitz, 2014-05-14 02:24:23]

R=adg



On Tue, May 13, 2014 at 6:33 PM, <chaishushan@gmail.com> wrote:

> Reviewers: golang-codereviews,
>
> Message:
> Hello golang-codereviews@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go-tour
>
>
> Description:
> go-tour: add missing delete/error/rune predeclared identifier for
> Syntax-Highlighting
>
> Please review this at https://codereview.appspot.com/99040045/
>
> Affected files (+3, -3 lines):
>   M static/lib/codemirror/mode/go/go.js
>
>
> Index: static/lib/codemirror/mode/go/go.js
> ===================================================================
> --- a/static/lib/codemirror/mode/go/go.js
> +++ b/static/lib/codemirror/mode/go/go.js
> @@ -8,15 +8,15 @@
>            "func":true, "go":true, "goto":true, "if":true, "import":true,
>            "interface":true, "map":true, "package":true, "range":true,
> "return":true,
>            "select":true, "struct":true, "switch":true, "type":true,
> "var":true,
> -          "bool":true, "byte":true, "complex64":true, "complex128":true,
> +          "bool":true, "byte":true, "complex64":true, "complex128":true,
> "error":true,
>            "float32":true, "float64":true, "int8":true, "int16":true,
> "int32":true,
> -          "int64":true, "string":true, "uint8":true, "uint16":true,
> "uint32":true,
> +          "int64":true, "rune":true, "string":true, "uint8":true,
> "uint16":true, "uint32":true,
>            "uint64":true, "int":true, "uint":true, "uintptr":true
>          };
>
>          var atoms = {
>            "true":true, "false":true, "iota":true, "nil":true,
> "append":true,
> -          "cap":true, "close":true, "complex":true, "copy":true,
> "imag":true,
> +          "cap":true, "close":true, "complex":true, "copy":true,
> "delete":true, "imag":true,
>            "len":true, "make":true, "new":true, "panic":true, "print":true,
>            "println":true, "real":true, "recover":true
>          };
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

[adg, 2014-05-14 03:31:52]

LGTM

[adg, 2014-05-14 03:38:06]

*** Submitted as https://code.google.com/p/go-tour/source/detail?r=c0237d6f6a0e
***

go-tour: add missing delete/error/rune predeclared identifier for
Syntax-Highlighting

LGTM=adg
R=golang-codereviews, bradfitz, adg
CC=golang-codereviews
https://codereview.appspot.com/99040045

Committer: Andrew Gerrand <adg@golang.org>