code review 989042: rpc/jsonrpc: support for jsonrpc wire encoding

rpc/jsonrpc: support for jsonrpc wire encoding

[rsc, 2010-04-27 18:48:38]

Hello r (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[r, 2010-04-27 19:34:52]

http://codereview.appspot.com/989042/diff/9001/10004
File src/pkg/rpc/jsonrpc/client.go (right):

http://codereview.appspot.com/989042/diff/9001/10004#newcode19
src/pkg/rpc/jsonrpc/client.go:19: dec  *json.Decoder
these fields could use some comments

http://codereview.appspot.com/989042/diff/9001/10004#newcode25
src/pkg/rpc/jsonrpc/client.go:25: mutex   sync.Mutex
especially these two

http://codereview.appspot.com/989042/diff/9001/10005
File src/pkg/rpc/jsonrpc/server.go (right):

http://codereview.appspot.com/989042/diff/9001/10005#newcode17
src/pkg/rpc/jsonrpc/server.go:17: enc *json.Encoder
again, comments please.

http://codereview.appspot.com/989042/diff/9001/10005#newcode21
src/pkg/rpc/jsonrpc/server.go:21: mu      sync.Mutex // protects seq, pending
this was called mutex in client code

[rsc, 2010-04-27 19:57:47]

Hello r (cc: golang-dev@googlegroups.com),

Please take another look.

[r, 2010-04-27 20:48:05]

LGTM

http://codereview.appspot.com/989042/diff/2002/17003
File src/pkg/rpc/jsonrpc/all_test.go (right):

http://codereview.appspot.com/989042/diff/2002/17003#newcode26
src/pkg/rpc/jsonrpc/all_test.go:26: func (t *Arith) Add(args *Args, reply
*Reply) os.Error {
sure is a handy little server

[rsc, 2010-04-27 20:52:12]

*** Submitted as http://code.google.com/p/go/source/detail?r=4b589ef3db44 ***

rpc/jsonrpc: support for jsonrpc wire encoding

R=r
CC=golang-dev
http://codereview.appspot.com/989042