Issue 98580047: code review 98580047: mime: sort attributes in FormatMediaType

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 98580047: code review 98580047: mime: sort attributes in FormatMediaType (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 11 months ago by bradfitz

Modified:
9 years, 11 months ago

Reviewers:
r, rsc

CC:
golang-codereviews, r, dsymonds, iant, rsc

Visibility:
Public.

Description

mime: sort attributes in FormatMediaType Map iteration order issue. Go 1.2 and earlier had stable results for small maps. Fixes Issue 8115

Patch Set 1 #

Patch Set 2 : diff -r 45f41a5c4d72 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 45f41a5c4d72 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 45f41a5c4d72 https://go.googlecode.com/hg/ #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -1 line)			Patch
	M	src/pkg/mime/mediatype.go	View	1	2 chunks	+9 lines, -1 line	0 comments	Download
	M	src/pkg/mime/mediatype_test.go	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

bradfitz

Hello golang-codereviews@googlegroups.com (cc: dsymonds@golang.org, iant@golang.org, r@golang.org, rsc@golang.org), I'd like you to review this change to ...

9 years, 11 months ago (2014-05-28 14:46:42 UTC) #1

bradfitz

9 years, 11 months ago (2014-05-28 15:16:18 UTC) #4

*** Submitted as https://code.google.com/p/go/source/detail?r=c160d357c4cd ***

mime: sort attributes in FormatMediaType

Map iteration order issue. Go 1.2 and earlier had stable results
for small maps.

Fixes Issue 8115

LGTM=r, rsc
R=golang-codereviews, r
CC=dsymonds, golang-codereviews, iant, rsc
https://codereview.appspot.com/98580047

Expand All Messages | Collapse All Messages