Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(579)

Issue 98570044: code review 98570044: go.tools/playground/socket: use IP for host/config matching (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 10 months ago by kortschak
Modified:
9 years, 8 months ago
Reviewers:
adg
CC:
golang-codereviews
Visibility:
Public.

Description

go.tools/playground/socket: use IP for host/config matching Fixes issue 8096.

Patch Set 1 : code review 98570044: go.tools/playground/socket: use IP for host/config matching #

Patch Set 2 : diff -r b6a3b105fbb0 https://code.google.com/p/go.tools #

Patch Set 3 : diff -r b6a3b105fbb0 https://code.google.com/p/go.tools #

Patch Set 4 : diff -r b6a3b105fbb0 https://code.google.com/p/go.tools #

Total comments: 4

Patch Set 5 : diff -r b6a3b105fbb0 https://code.google.com/p/go.tools #

Patch Set 6 : diff -r b6a3b105fbb0 https://code.google.com/p/go.tools #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -1 line) Patch
M playground/socket/socket.go View 1 2 3 4 5 3 chunks +50 lines, -1 line 0 comments Download

Messages

Total messages: 5
kortschak
Hello adg@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.tools
9 years, 10 months ago (2014-05-26 05:06:08 UTC) #1
adg
I think there are other security concerns here. Alice is running a present server at ...
9 years, 10 months ago (2014-05-26 11:12:58 UTC) #2
kortschak
PTAL > I think there are other security concerns here. > Alice is running a ...
9 years, 10 months ago (2014-05-26 11:56:29 UTC) #3
kortschak
*** Abandoned ***
9 years, 10 months ago (2014-05-29 12:05:15 UTC) #4
kortschak
9 years, 8 months ago (2014-07-08 01:35:36 UTC) #5
Message was sent while issue was closed.
*** Abandoned ***
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b