Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1103)

Issue 98370044: code review 98370044: go.tools/cmd/vet: clean up formatting of the package do... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 10 months ago by r
Modified:
9 years, 10 months ago
Reviewers:
bradfitz
CC:
golang-codereviews, bradfitz
Visibility:
Public.

Description

go.tools/cmd/vet: clean up formatting of the package document It was very ugly; a little tweaking helps godoc parse it better. Also make unsafeptr.go not own the package doc (add a blank line) and put one more sentence about that check into doc.go. Fixes issue 7925.

Patch Set 1 #

Patch Set 2 : diff -r 8b7925c24d4c https://code.google.com/p/go.tools #

Patch Set 3 : diff -r a7604d0a74e3 https://code.google.com/p/go.tools #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -41 lines) Patch
M cmd/vet/doc.go View 1 3 chunks +33 lines, -29 lines 0 comments Download
M cmd/vet/unsafeptr.go View 1 chunk +1 line, -12 lines 0 comments Download

Messages

Total messages: 3
r
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go.tools
9 years, 10 months ago (2014-05-19 18:22:13 UTC) #1
bradfitz
LGTM
9 years, 10 months ago (2014-05-19 18:24:49 UTC) #2
r
9 years, 10 months ago (2014-05-19 18:34:18 UTC) #3
*** Submitted as
https://code.google.com/p/go/source/detail?r=3dc9790d6465&repo=tools ***

go.tools/cmd/vet: clean up formatting of the package document
It was very ugly; a little tweaking helps godoc parse it better.
Also make unsafeptr.go not own the package doc (add a blank line)
and put one more sentence about that check into doc.go.

Fixes issue 7925.

LGTM=bradfitz
R=golang-codereviews, bradfitz
CC=golang-codereviews
https://codereview.appspot.com/98370044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b