Issue 98150043: code review 98150043: testing: add Coverage function

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 98150043: code review 98150043: testing: add Coverage function (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 11 months ago by rsc

Modified:
9 years, 9 months ago

Reviewers:
r, gobot

CC:
r, golang-codereviews

Visibility:
Public.

Description

testing: add Coverage function I've found this very useful for generating good test case lists for -short mode for the disassemblers. Fixes issue 7959.

Patch Set 2 : diff -r 8f49b5cc8196 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 6f69b178e6d9 https://code.google.com/p/go/ #

Total comments: 2

Patch Set 4 : diff -r ef2344f636e4 https://code.google.com/p/go/ #

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -0 lines)			Patch
	M	doc/go1.4.txt	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	src/pkg/testing/cover.go	View		1 chunk	+23 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

rsc

Hello r (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

9 years, 9 months ago (2014-07-17 16:20:00 UTC) #1

LGTM 1.4.txt please https://codereview.appspot.com/98150043/diff/30001/src/pkg/testing/cover.go File src/pkg/testing/cover.go (right): https://codereview.appspot.com/98150043/diff/30001/src/pkg/testing/cover.go#newcode40 src/pkg/testing/cover.go:40: // When running a large set ...

9 years, 9 months ago (2014-07-17 17:19:02 UTC) #2

rsc

https://codereview.appspot.com/98150043/diff/30001/src/pkg/testing/cover.go File src/pkg/testing/cover.go (right): https://codereview.appspot.com/98150043/diff/30001/src/pkg/testing/cover.go#newcode40 src/pkg/testing/cover.go:40: // When running a large set of test cases, ...

9 years, 9 months ago (2014-07-23 02:56:16 UTC) #3

rsc

*** Submitted as https://code.google.com/p/go/source/detail?r=13d806a8d380 *** testing: add Coverage function I've found this very useful for ...

9 years, 9 months ago (2014-07-23 02:56:40 UTC) #4

gobot

9 years, 9 months ago (2014-07-23 03:41:48 UTC) #5

Message was sent while issue was closed.

This CL appears to have broken the freebsd-amd64-race builder.
See http://build.golang.org/log/e8154a1cb832d38d4dbaa9f9160fd0255018ebe0

Expand All Messages | Collapse All Messages