code review 98080043: net: drop flakey TestDialFailPDLeak

net: drop flakey TestDialFailPDLeak

TestDialFailPDLeak was created for testing runtime-integrated netwrok
poller stuff and used during Go 1.2 development cycle. Unfortunately
it's still flakey because it depends on MemStats of runtime, not
pollcache directly, and MemStats accounts and revises its own stats
occasionally.

For now the codepaths related to runtime-intergrated network poller
are pretty stable, so removing this test case never suffers us.

Fixes issue 6553.

[mikio, 2014-05-08 00:58:29]

Hello iant@golang.org, josharian@gmail.com (cc:
golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[josharian, 2014-05-08 01:04:36]

LGTM but wait for iant

If you'd still like to fix this eventually to prevent regressions, you could
instead just t.Skip referencing issue 6553, and change the description to
"Update issue 6553".

[mikio, 2014-05-08 01:14:52]

On Thu, May 8, 2014 at 10:04 AM,  <josharian@gmail.com> wrote:

> If you'd still like to fix this eventually to prevent regressions, you
> could instead just t.Skip referencing issue 6553, and change the
> description to "Update issue 6553".

if needed we'll add a new test case in the future, but it might be a
simple approach; just adding pollcache stats os so.

[josharian, 2014-05-08 01:18:46]

> > If you'd still like to fix this eventually to prevent regressions, you
> > could instead just t.Skip referencing issue 6553, and change the
> > description to "Update issue 6553".
> 
> if needed we'll add a new test case in the future, but it might be a
> simple approach; just adding pollcache stats os so.

SGTM

[mikio, 2014-05-08 21:54:00]

iant?

[iant, 2014-05-08 23:59:43]

LGTM

[mikio, 2014-05-09 00:38:35]

*** Submitted as https://code.google.com/p/go/source/detail?r=209bb94bd691 ***

net: drop flakey TestDialFailPDLeak

TestDialFailPDLeak was created for testing runtime-integrated netwrok
poller stuff and used during Go 1.2 development cycle. Unfortunately
it's still flakey because it depends on MemStats of runtime, not
pollcache directly, and MemStats accounts and revises its own stats
occasionally.

For now the codepaths related to runtime-intergrated network poller
are pretty stable, so removing this test case never suffers us.

Fixes issue 6553.

LGTM=josharian, iant
R=iant, josharian
CC=golang-codereviews
https://codereview.appspot.com/98080043