Issue 97920044: code review 97920044: cmd/ld: correct pe section number in symbol table

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 97920044: code review 97920044: cmd/ld: correct pe section number in symbol table (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years ago by brainman

Modified:
10 years ago

Reviewers:
gobot, iant

CC:
golang-codereviews, rsc, iant

Visibility:
Public.

cmd/ld: correct pe section number in symbol table Update issue 7899

Created: 10 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -18 lines)			Patch
	M	src/cmd/ld/pe.c	View	1	4 chunks	+17 lines, -18 lines	0 comments	Download

Total messages: 5

brainman

Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

10 years ago (2014-05-02 07:39:32 UTC) #1

brainman

*** Submitted as https://code.google.com/p/go/source/detail?r=2b8ee33fbca8 *** cmd/ld: correct pe section number in symbol table Update issue ...

10 years ago (2014-05-06 01:40:49 UTC) #4

gobot

10 years ago (2014-05-06 01:53:44 UTC) #5

Message was sent while issue was closed.

This CL appears to have broken the darwin-amd64-cheney builder.
See http://build.golang.org/log/70de7f45884f9e1788d9b4fb5b3ee0e7b1ac65be