Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1249)

Issue 97850043: code review 97850043: go.crypto/ssh/terminal: add support for BSD variants (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 11 months ago by mikio
Modified:
9 years, 10 months ago
Reviewers:
agl1
CC:
golang-codereviews, agl1
Visibility:
Public.

Description

go.crypto/ssh/terminal: add support for BSD variants

Patch Set 1 : diff -r 5478be1963aa https://code.google.com/p/go.crypto #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M ssh/terminal/util.go View 1 chunk +1 line, -1 line 0 comments Download
M ssh/terminal/util_bsd.go View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
mikio
Hello golang-codereviews@googlegroups.com (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.crypto
9 years, 11 months ago (2014-04-30 08:43:46 UTC) #1
agl1
LGTM. (I'm assuming that you tested that it actually works.)
9 years, 10 months ago (2014-05-05 19:07:11 UTC) #2
agl1
9 years, 10 months ago (2014-05-05 19:07:38 UTC) #3
*** Submitted as
https://code.google.com/p/go/source/detail?r=20463e0f30fb&repo=crypto ***

go.crypto/ssh/terminal: add support for BSD variants

LGTM=agl
R=golang-codereviews, agl
CC=golang-codereviews
https://codereview.appspot.com/97850043

Committer: Adam Langley <agl@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b