Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(298)

Issue 97840043: code review 97840043: cmd/go: mark regexp as dependency of testmain (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years ago by rh
Modified:
10 years ago
Reviewers:
rsc, cespare
CC:
golang-codereviews, rsc
Visibility:
Public.

Description

cmd/go: mark regexp as dependency of testmain Fixes issue 6844.

Patch Set 1 #

Patch Set 2 : diff -r 824f981dd4b7 https://code.google.com/p/go #

Patch Set 3 : diff -r 824f981dd4b7 https://code.google.com/p/go #

Patch Set 4 : diff -r 824f981dd4b7 https://code.google.com/p/go #

Patch Set 5 : diff -r 15e9d3c5d705 https://code.google.com/p/go #

Patch Set 6 : diff -r 15e9d3c5d705 https://code.google.com/p/go #

Patch Set 7 : code review 97840043: cmd/go: mark regexp as dependency of testmain #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-1 lines, --1 lines) Patch
~rietveld~placeholder~ View 2 3 4 5 6 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 6
rh
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
10 years ago (2014-04-30 02:54:57 UTC) #1
rsc
LGTM
10 years ago (2014-05-02 16:00:13 UTC) #2
rh
I just realized I completely forgot to include dep_test.go. My apologies. I'll fix this.
10 years ago (2014-05-02 16:09:17 UTC) #3
rh
Hello golang-codereviews@googlegroups.com, rsc@golang.org (cc: golang-codereviews@googlegroups.com), Please take another look.
10 years ago (2014-05-02 16:25:40 UTC) #4
rsc
*** Submitted as https://code.google.com/p/go/source/detail?r=8f49b5cc8196 *** cmd/go: mark regexp as dependency of testmain Fixes issue 6844. ...
10 years ago (2014-05-09 16:19:04 UTC) #5
cespare
10 years ago (2014-05-09 17:57:57 UTC) #6
On 2014/05/09 16:19:04, rsc wrote:
> *** Submitted as https://code.google.com/p/go/source/detail?r=8f49b5cc8196 ***
> 
> cmd/go: mark regexp as dependency of testmain
> 
> Fixes issue 6844.
> 
> LGTM=rsc
> R=golang-codereviews, rsc
> CC=golang-codereviews
> https://codereview.appspot.com/97840043
> 
> Committer: Russ Cox <mailto:rsc@golang.org>

Hey Russ, looks like there are merge markers in commit (/src/cmd/go/test.bash).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b