code review 9780050: [release-branch.go1.1] runtime: introduce cnewarray() t...

[release-branch.go1.1] runtime: introduce cnewarray() to simplify allocation of typed arrays

««« CL 9648044 / 139919984600
runtime: introduce cnewarray() to simplify allocation of typed arrays

R=golang-dev, dsymonds
CC=golang-dev
https://codereview.appspot.com/9648044
»»»

[adg, 2013-06-03 23:47:51]

Hello dsymonds, dvyukov (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[dfc, 2013-06-03 23:56:52]

I don't see a link to a Go1.1.1 tagged issue from CL 9648044, was this
the correct CL to merge ?

On Tue, Jun 4, 2013 at 9:47 AM,  <adg@golang.org> wrote:
> Reviewers: dsymonds, dvyukov,
>
> Message:
> Hello dsymonds, dvyukov (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change to
> https://code.google.com/p/go
>
>
> Description:
> [release-branch.go1.1] runtime: introduce cnewarray() to simplify
> allocation of typed arrays
>
> ««« CL 9648044 / 139919984600
> runtime: introduce cnewarray() to simplify allocation of typed arrays
>
> R=golang-dev, dsymonds
> CC=golang-dev
> https://codereview.appspot.com/9648044
> »»»
>
>
> Please review this at https://codereview.appspot.com/9780050/
>
> Affected files:
>   M src/pkg/reflect/all_test.go
>   M src/pkg/runtime/iface.c
>   M src/pkg/runtime/malloc.goc
>   M src/pkg/runtime/malloc.h
>   M src/pkg/runtime/slice.c
>
>
> --
>
> ---You received this message because you are subscribed to the Google Groups
> "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-dev+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>
>

[dsymonds, 2013-06-04 00:53:56]

LGTM

[dfc, 2013-06-04 01:08:55]

LGTM. Please ignore my earlier comment.



On 04/06/2013, at 9:47, adg@golang.org wrote:

> Reviewers: dsymonds, dvyukov,
> 
> Message:
> Hello dsymonds, dvyukov (cc: golang-dev@googlegroups.com),
> 
> I'd like you to review this change to
> https://code.google.com/p/go
> 
> 
> Description:
> [release-branch.go1.1] runtime: introduce cnewarray() to simplify
> allocation of typed arrays
> 
> ««« CL 9648044 / 139919984600
> runtime: introduce cnewarray() to simplify allocation of typed arrays
> 
> R=golang-dev, dsymonds
> CC=golang-dev
> https://codereview.appspot.com/9648044
> »»»
> 
> 
> Please review this at https://codereview.appspot.com/9780050/
> 
> Affected files:
>  M src/pkg/reflect/all_test.go
>  M src/pkg/runtime/iface.c
>  M src/pkg/runtime/malloc.goc
>  M src/pkg/runtime/malloc.h
>  M src/pkg/runtime/slice.c
> 
> 
> -- 
> 
> ---You received this message because you are subscribed to the Google Groups
"golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
email to golang-dev+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
> 
> 

[adg, 2013-06-04 02:54:18]

*** Submitted as https://code.google.com/p/go/source/detail?r=74e2ffd333e9 ***

[release-branch.go1.1] runtime: introduce cnewarray() to simplify allocation of
typed arrays

««« CL 9648044 / 139919984600
runtime: introduce cnewarray() to simplify allocation of typed arrays

R=golang-dev, dsymonds
CC=golang-dev
https://codereview.appspot.com/9648044
»»»

R=dsymonds, dvyukov, dave
CC=golang-dev
https://codereview.appspot.com/9780050