code review 97780045: log/syslog: document if network=="" for Dial, it will c...

log/syslog: document if network=="" for Dial, it will connect to local syslog server.
Fixes issue 7828.

[minux1, 2014-04-28 04:54:44]

Hello golang-codereviews@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[rh, 2014-04-28 12:40:14]

LGTM

https://codereview.appspot.com/97780045/diff/40001/src/pkg/log/syslog/syslog.go
File src/pkg/log/syslog/syslog.go (right):

https://codereview.appspot.com/97780045/diff/40001/src/pkg/log/syslog/syslog....
src/pkg/log/syslog/syslog.go:118: // address raddr on the network net.  Each
write to the returned
While you're here, net seems to no longer be the parameter name for network.
s/network net/specified network/ maybe?

[iant, 2014-04-28 16:40:28]

LGTM

[minux1, 2014-04-28 18:26:13]

Hello golang-codereviews@googlegroups.com, robert.hencke@gmail.com,
iant@golang.org (cc: golang-codereviews@googlegroups.com),

Please take another look.

[bradfitz, 2014-04-28 18:28:16]

LGTM


On Sun, Apr 27, 2014 at 9:54 PM, <minux.ma@gmail.com> wrote:

> Reviewers: golang-codereviews,
>
> Message:
> Hello golang-codereviews@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go
>
>
> Description:
> log/syslog: document if network=="" for Dial, it will connect to local
> syslog server.
> Fixes issue 7628.
>
> Please review this at https://codereview.appspot.com/97780045/
>
> Affected files (+1, -0 lines):
>   M src/pkg/log/syslog/syslog.go
>
>
> Index: src/pkg/log/syslog/syslog.go
> ===================================================================
> --- a/src/pkg/log/syslog/syslog.go
> +++ b/src/pkg/log/syslog/syslog.go
> @@ -118,6 +118,7 @@
>  // address raddr on the network net.  Each write to the returned
>  // writer sends a log message with the given facility, severity and
>  // tag.
> +// If network is empty, Dial will connect to the local syslog server.
>  func Dial(network, raddr string, priority Priority, tag string) (*Writer,
> error) {
>         if priority < 0 || priority > LOG_LOCAL7|LOG_DEBUG {
>                 return nil, errors.New("log/syslog: invalid priority")
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

[minux1, 2014-04-28 18:29:49]

*** Submitted as https://code.google.com/p/go/source/detail?r=46ac9e6796a3 ***

log/syslog: document if network=="" for Dial, it will connect to local syslog
server.
Fixes issue 7828.

LGTM=robert.hencke, iant, bradfitz
R=golang-codereviews, robert.hencke, iant, bradfitz
CC=golang-codereviews
https://codereview.appspot.com/97780045

[gobot, 2014-04-28 19:01:18]

This CL appears to have broken the openbsd-386-rootbsd builder.
See http://build.golang.org/log/9042fab0d73bcef443ae314816c8899240e93582

[minux1, 2014-04-28 19:23:24]

On Mon, Apr 28, 2014 at 3:01 PM, <gobot@golang.org> wrote:

> This CL appears to have broken the openbsd-386-rootbsd builder.
> See http://build.golang.org/log/9042fab0d73bcef443ae314816c8899240e93582

--- FAIL: TestAfterQueuing (1.03 seconds)
 sleep_test.go:214: attempt 0 failed: After(20ms) arrived at 239.913453ms,
expected [10ms,220ms]
sleep_test.go:214: attempt 1 failed: After(20ms) arrived at 409.366554ms,
expected [10ms,220ms]
 sleep_test.go:214: attempt 2 failed: After(20ms) arrived at 269.736517ms,
expected [10ms,220ms]
sleep_test.go:218: After(20ms) arrived at 269.736517ms, expected
[10ms,220ms]
FAIL
FAIL time 5.794s

It's unrelated.