code review 9777043: ssh/terminal: support home, end, up and down keys.

ssh/terminal: support home, end, up and down keys.

[agl1, 2013-05-25 19:09:37]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go.crypto/

[dfc, 2013-05-28 12:40:59]

LGTM, but I feel uncomfortable without a test.

On Sun, May 26, 2013 at 5:09 AM,  <agl@golang.org> wrote:
> Reviewers: golang-dev1,
>
> Message:
> Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change to
> https://code.google.com/p/go.crypto/
>
>
> Description:
> ssh/terminal: support home, end, up and down keys.
>
> Please review this at https://codereview.appspot.com/9777043/
>
> Affected files:
>   M ssh/terminal/terminal.go
>
>
> --
>
> ---You received this message because you are subscribed to the Google Groups
> "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-dev+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>
>

[agl1, 2013-06-07 14:20:51]

On 2013/05/28 12:40:59, dfc wrote:
> LGTM, but I feel uncomfortable without a test.

Test added.

[agl1, 2013-06-07 14:23:30]

*** Submitted as
https://code.google.com/p/go/source/detail?r=627fbe8ff755&repo=crypto ***

ssh/terminal: support home, end, up and down keys.

R=golang-dev, dave
CC=golang-dev
https://codereview.appspot.com/9777043

[dfc, 2013-06-08 00:37:18]

Thanks. Sorry I didn't have time to review it for you. 

On 08/06/2013, at 0:23, agl@golang.org wrote:

> *** Submitted as
> https://code.google.com/p/go/source/detail?r=627fbe8ff755&repo=crypto
> ***
> 
> ssh/terminal: support home, end, up and down keys.
> 
> R=golang-dev, dave
> CC=golang-dev
> https://codereview.appspot.com/9777043
> 
> 
> https://codereview.appspot.com/9777043/