Issue 97590043: code review 97590043: net/http: document that ProxyFromEnvironment special-ca...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 97590043: code review 97590043: net/http: document that ProxyFromEnvironment special-ca... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years ago by bradfitz

Modified:
10 years ago

Reviewers:
r

CC:
golang-codereviews, r, rsc

Visibility:
Public.

Description

net/http: document that ProxyFromEnvironment special-cases localhost Fixes Issue 7256

Patch Set 1 #

Patch Set 2 : diff -r 0d7a1ac60a57 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 0d7a1ac60a57 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 62840fa688d8 https://go.googlecode.com/hg/ #

Created: 10 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	src/pkg/net/http/transport.go	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

bradfitz

Hello golang-codereviews@googlegroups.com (cc: r@golang.org, rsc@golang.org), I'd like you to review this change to https://go.googlecode.com/hg/

10 years ago (2014-05-19 16:52:27 UTC) #1

bradfitz

10 years ago (2014-05-19 17:12:18 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=abe528ee4a57 ***

net/http: document that ProxyFromEnvironment special-cases localhost

Fixes Issue 7256

LGTM=r
R=golang-codereviews, r
CC=golang-codereviews, rsc
https://codereview.appspot.com/97590043

Expand All Messages | Collapse All Messages