Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(8872)

Issue 97570046: code review 97570046: encoding/xml: Trim XML tags correctly before printing chardata.

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 11 months ago by hajimehoshi
Modified:
9 years, 4 months ago
Reviewers:
CC:
golang-codereviews, bradfitz, rsc
Visibility:
Public.

Description

encoding/xml: Trim XML tags correctly before printing chardata. This fixes issue 5072. This doesn't consider about fixed-size arrays. (AFAIK, (a part of) an xml can't be unmarshaled to fixed-size arrays.)

Patch Set 1 #

Patch Set 2 : diff -r 962157789bb0 https://code.google.com/p/go #

Patch Set 3 : diff -r 962157789bb0 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M src/pkg/encoding/xml/marshal.go View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/pkg/encoding/xml/marshal_test.go View 1 2 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 6
hajimehoshi
Hello golang-dev@googlegroups.com (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
9 years, 11 months ago (2014-05-21 10:04:36 UTC) #1
gobot
Replacing golang-dev with golang-codereviews. To the author of this CL: If you are using 'hg ...
9 years, 11 months ago (2014-05-21 10:08:23 UTC) #2
hajimehoshi
ping
9 years, 10 months ago (2014-06-23 08:33:50 UTC) #3
bradfitz
R=rsc
9 years, 10 months ago (2014-06-23 17:36:09 UTC) #4
hajimehoshi
I was wondering someone would review this.
9 years, 8 months ago (2014-07-30 06:21:23 UTC) #5
gobot
9 years, 4 months ago (2014-12-19 05:19:30 UTC) #6
R=close

To the author of this CL:

The Go project has moved to Gerrit Code Review.

If this CL should be continued, please see the latest version of
https://golang.org/doc/contribute.html for instructions on
how to set up Git and the Go project's Gerrit codereview plugin,
and then create a new change with your current code.

If there has been discussion on this CL, please give a link to it
(golang.org/cl/97570046 is best) in the description in your
new CL.

Thanks very much.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b