Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(968)

Issue 97550043: code review 97550043: runtime: fix freeOSMemory to free memory immediately (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 11 months ago by dvyukov
Modified:
9 years, 11 months ago
Reviewers:
gobot, khr
CC:
golang-codereviews, khr, rsc
Visibility:
Public.

Description

runtime: fix freeOSMemory to free memory immediately Currently freeOSMemory makes only marking phase of GC, but not sweeping phase. So recently memory is not released after freeOSMemory. Do both marking and sweeping during freeOSMemory. Fixes issue 8019.

Patch Set 1 #

Patch Set 2 : diff -r 2cd1027581fa https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 3 : diff -r 2cd1027581fa https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 4 : diff -r 2cd1027581fa https://dvyukov%40google.com@code.google.com/p/go/ #

Total comments: 2

Patch Set 5 : diff -r ef9cb6cd63cb https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 6 : diff -r ef9cb6cd63cb https://dvyukov%40google.com@code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -13 lines) Patch
M src/pkg/runtime/malloc.goc View 1 1 chunk +1 line, -10 lines 0 comments Download
M src/pkg/runtime/mgc0.c View 1 2 3 4 5 chunks +6 lines, -2 lines 0 comments Download
M src/pkg/runtime/mheap.c View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5
dvyukov
Hello golang-codereviews@googlegroups.com (cc: khr@golang.org, rsc@golang.org), I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/
9 years, 11 months ago (2014-05-18 07:43:13 UTC) #1
khr
LGTM https://codereview.appspot.com/97550043/diff/60001/src/pkg/runtime/mgc0.c File src/pkg/runtime/mgc0.c (right): https://codereview.appspot.com/97550043/diff/60001/src/pkg/runtime/mgc0.c#newcode2298 src/pkg/runtime/mgc0.c:2298: if(!force && mstats.heap_alloc < mstats.next_gc) { change !force ...
9 years, 11 months ago (2014-05-18 08:16:44 UTC) #2
dvyukov
https://codereview.appspot.com/97550043/diff/60001/src/pkg/runtime/mgc0.c File src/pkg/runtime/mgc0.c (right): https://codereview.appspot.com/97550043/diff/60001/src/pkg/runtime/mgc0.c#newcode2298 src/pkg/runtime/mgc0.c:2298: if(!force && mstats.heap_alloc < mstats.next_gc) { On 2014/05/18 08:16:44, ...
9 years, 11 months ago (2014-05-19 08:06:14 UTC) #3
dvyukov
*** Submitted as https://code.google.com/p/go/source/detail?r=80c5e57e2ec3 *** runtime: fix freeOSMemory to free memory immediately Currently freeOSMemory makes ...
9 years, 11 months ago (2014-05-19 08:06:34 UTC) #4
gobot
9 years, 11 months ago (2014-05-19 08:16:31 UTC) #5
Message was sent while issue was closed.
This CL appears to have broken the openbsd-386-rootbsd builder.
See http://build.golang.org/log/f52d78b8ddc1426d39e86abac6e25740ccc56516
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b