code review 9752044: runtime: explicit init of runtime-gdb helpers

runtime: explicit init of runtime-gdb helpers

If using other gdb python scripts loaded before Go's gdb-runtime.py
and that have a different init prototype:
Traceback (most recent call last):
  File "/usr/lib/go/src/pkg/runtime/runtime-gdb.py", line 446, in <module>
    k()
TypeError: __init__() takes exactly 3 arguments (1 given)

The problem is that gdb keeps all python scripts in the same namespace,
so vars() contains them. To avoid that, load helpers one by one.

[ail, 2013-05-25 14:19:46]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[gobot, 2013-05-25 17:21:15]

R=iant (assigned by r)

[ail, 2013-09-10 12:16:05]

Friendly ping.

[rsc, 2013-09-10 16:53:37]

LGTM

[rsc, 2013-09-10 17:00:12]

*** Submitted as https://code.google.com/p/go/source/detail?r=b24fe3a40fc7 ***

runtime: explicit init of runtime-gdb helpers

If using other gdb python scripts loaded before Go's gdb-runtime.py
and that have a different init prototype:
Traceback (most recent call last):
  File "/usr/lib/go/src/pkg/runtime/runtime-gdb.py", line 446, in <module>
    k()
TypeError: __init__() takes exactly 3 arguments (1 given)

The problem is that gdb keeps all python scripts in the same namespace,
so vars() contains them. To avoid that, load helpers one by one.

R=iant, rsc
CC=gobot, golang-dev
https://codereview.appspot.com/9752044

Committer: Russ Cox <rsc@golang.org>