Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(778)

Issue 9738052: code review 9738052: testing: add test for issue 5599 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 10 months ago by dfc
Modified:
10 years, 10 months ago
Reviewers:
r
CC:
golang-dev, r, minux1
Visibility:
Public.

Description

testing: add test for issue 5599 Update issue 5599

Patch Set 1 #

Patch Set 2 : diff -r 77be301f21af https://code.google.com/p/go #

Patch Set 3 : diff -r 77be301f21af https://code.google.com/p/go #

Patch Set 4 : diff -r 1faca3687fe6 https://code.google.com/p/go #

Patch Set 5 : diff -r 1faca3687fe6 https://code.google.com/p/go #

Patch Set 6 : diff -r 1faca3687fe6 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -0 lines) Patch
A src/pkg/testing/benchmark_test.go View 1 2 3 4 1 chunk +31 lines, -0 lines 0 comments Download
A src/pkg/testing/export_test.go View 1 2 3 4 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 8
dfc
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
10 years, 10 months ago (2013-05-31 12:24:52 UTC) #1
r
LGTM
10 years, 10 months ago (2013-05-31 12:31:14 UTC) #2
minux1
seems not worth the trouble to split the actual fix and the test into two ...
10 years, 10 months ago (2013-05-31 12:35:00 UTC) #3
dfc
Opps, I forgot the copyright notices. Adding them now. On Fri, May 31, 2013 at ...
10 years, 10 months ago (2013-05-31 12:37:30 UTC) #4
dfc
Hi Minux, I think the fix might be a little harder than expected, try it ...
10 years, 10 months ago (2013-05-31 12:38:46 UTC) #5
dfc
Hello golang-dev@googlegroups.com, r@golang.org, minux.ma@gmail.com (cc: golang-dev@googlegroups.com), Please take another look.
10 years, 10 months ago (2013-05-31 12:39:30 UTC) #6
r
LGTM
10 years, 10 months ago (2013-05-31 13:00:11 UTC) #7
dfc
10 years, 10 months ago (2013-05-31 13:03:36 UTC) #8
*** Submitted as https://code.google.com/p/go/source/detail?r=fd791d51e476 ***

testing: add test for issue 5599

Update issue 5599

R=golang-dev, r, minux.ma
CC=golang-dev
https://codereview.appspot.com/9738052
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b