Issue 9736043: code review 9736043: crypto/x509: harmonise error prefixes.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 9736043: code review 9736043: crypto/x509: harmonise error prefixes. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 10 months ago by agl1

Modified:
11 years, 10 months ago

Reviewers:
r

CC:
golang-dev, r

Visibility:
Public.

Description

crypto/x509: harmonise error prefixes. crypto/x509 has ended up with a variety of error formats. This change makes them all start with "x509: ".

Patch Set 1 #

Patch Set 2 : diff -r 79a1fec35802 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 79a1fec35802 https://code.google.com/p/go/ #

Patch Set 4 : diff -r 69000c52c3ab https://code.google.com/p/go/ #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -22 lines)			Patch
M	src/pkg/crypto/x509/pkcs1.go	View	1 2 3	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/pkg/crypto/x509/pkcs8.go	View	1 2 3	2 chunks	+3 lines, -3 lines	0 comments	Download
M	src/pkg/crypto/x509/sec1.go	View	1 2 3	2 chunks	+4 lines, -4 lines	0 comments	Download
M	src/pkg/crypto/x509/x509.go	View	1 2 3	10 chunks	+13 lines, -13 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

agl1

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

11 years, 10 months ago (2013-05-24 17:09:59 UTC) #1

agl1

(cc'ing r, since I'm not sure whether "crypto/x509" is a better prefix than "x509".)

11 years, 10 months ago (2013-05-24 17:10:58 UTC) #2

LGtm i prefer x509, so change it if you like, but either is ok.

11 years, 10 months ago (2013-05-24 17:30:36 UTC) #3

agl1

11 years, 10 months ago (2013-05-24 20:25:05 UTC) #5

*** Submitted as https://code.google.com/p/go/source/detail?r=5993bd419cf0 ***

crypto/x509: harmonise error prefixes.

crypto/x509 has ended up with a variety of error formats. This change makes them
all start with "x509: ".

R=golang-dev, r
CC=golang-dev
https://codereview.appspot.com/9736043

Expand All Messages | Collapse All Messages