code review 96850043: src: fix issues found by go vet std

src: fix issues found by go vet std

[rh, 2014-04-26 20:27:08]

Hello golang-codereviews@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[iant, 2014-04-27 02:54:42]

LGTM

Thanks.

[iant, 2014-04-27 02:54:51]

*** Submitted as https://code.google.com/p/go/source/detail?r=ca37ca589729 ***

src: fix issues found by go vet std

LGTM=iant
R=golang-codereviews, iant
CC=golang-codereviews
https://codereview.appspot.com/96850043

Committer: Ian Lance Taylor <iant@golang.org>

[gobot, 2014-04-27 03:07:25]

This CL appears to have broken the linux-arm-cheney-imx6 builder.
See http://build.golang.org/log/dddc4b7fd41105d7780e541431d33b37c6c42bad

[iant, 2014-04-27 03:08:50]

On Sat, Apr 26, 2014 at 8:07 PM,  <gobot@golang.org> wrote:
> This CL appears to have broken the linux-arm-cheney-imx6 builder.
> See http://build.golang.org/log/dddc4b7fd41105d7780e541431d33b37c6c42bad
>
> https://codereview.appspot.com/96850043/

Not really.

# GOMAXPROCS=2 runtime -cpu=1,2,4
--- FAIL: TestStackGrowth-4 (25.58 seconds)
stack_test.go:166: finalizer did not run
FAIL
FAIL runtime 149.035s
Build complete, duration 11m20.799443757s. Result: error: exit status 1

Ian

[rh, 2014-04-27 03:38:41]

Thanks for checking on this.

On Saturday, April 26, 2014 11:08:50 PM UTC-4, Ian Lance Taylor wrote:
>
> On Sat, Apr 26, 2014 at 8:07 PM,  <go...@golang.org <javascript:>> wrote: 
> > This CL appears to have broken the linux-arm-cheney-imx6 builder. 
> > See http://build.golang.org/log/dddc4b7fd41105d7780e541431d33b37c6c42bad 
> > 
> > https://codereview.appspot.com/96850043/ 
>
> Not really. 
>
> # GOMAXPROCS=2 runtime -cpu=1,2,4 
> --- FAIL: TestStackGrowth-4 (25.58 seconds) 
> stack_test.go:166: finalizer did not run 
> FAIL 
> FAIL runtime 149.035s 
> Build complete, duration 11m20.799443757s. Result: error: exit status 1 
>
> Ian 
>