Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(670)

Issue 96830045: code review 96830045: doc/debugging_with_gdb.html: add introductory disclaimer (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 11 months ago by r
Modified:
10 years, 11 months ago
Reviewers:
iant, josharian
CC:
golang-codereviews, josharian, iant
Visibility:
Public.

Description

doc/debugging_with_gdb.html: add introductory disclaimer The instructions in this document are useful but not reliable. Explain the situation up top. Fixes issue 7471.

Patch Set 1 #

Total comments: 1

Patch Set 2 : diff -r 7da10a02f6dd https://code.google.com/p/go/ #

Total comments: 1

Patch Set 3 : diff -r 7da10a02f6dd https://code.google.com/p/go/ #

Patch Set 4 : diff -r fa39a7dac971 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -0 lines) Patch
M doc/debugging_with_gdb.html View 1 2 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 7
r
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/
10 years, 11 months ago (2014-04-26 15:23:26 UTC) #1
josharian
LGTM with nits https://codereview.appspot.com/96830045/diff/1/doc/debugging_with_gdb.html File doc/debugging_with_gdb.html (right): https://codereview.appspot.com/96830045/diff/1/doc/debugging_with_gdb.html#newcode16 doc/debugging_with_gdb.html:16: the debugger, even those compiled with ...
10 years, 11 months ago (2014-04-26 15:37:25 UTC) #2
r
Hello golang-codereviews@googlegroups.com, josharian@gmail.com (cc: golang-codereviews@googlegroups.com), Please take another look.
10 years, 11 months ago (2014-04-26 15:41:35 UTC) #3
josharian
LGTM https://codereview.appspot.com/96830045/diff/20001/doc/debugging_with_gdb.html File doc/debugging_with_gdb.html (right): https://codereview.appspot.com/96830045/diff/20001/doc/debugging_with_gdb.html#newcode16 doc/debugging_with_gdb.html:16: the debugger, even when the program is compiled ...
10 years, 11 months ago (2014-04-26 15:44:09 UTC) #4
r
Apologies, I missed that the first time around. Will fix and wait for more comments. ...
10 years, 11 months ago (2014-04-26 15:51:25 UTC) #5
iant
LGTM
10 years, 11 months ago (2014-04-26 16:06:24 UTC) #6
r
10 years, 11 months ago (2014-04-26 16:18:19 UTC) #7
*** Submitted as https://code.google.com/p/go/source/detail?r=d4d38f1aa322 ***

doc/debugging_with_gdb.html: add introductory disclaimer
The instructions in this document are useful but not reliable.
Explain the situation up top.

Fixes issue 7471.

LGTM=josharian, iant
R=golang-codereviews, josharian, iant
CC=golang-codereviews
https://codereview.appspot.com/96830045
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b