Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3355)

Issue 96830044: code review 96830044: encoding/gob: handle interface types in isZero() ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 11 months ago by jonallie
Modified:
9 years, 11 months ago
Reviewers:
r
CC:
golang-codereviews, r
Visibility:
Public.

Description

encoding/gob: handle interface types in isZero() by returning true for nil interfaces. Fixes issue 7741.

Patch Set 1 : diff -r fa39a7dac971 https://code.google.com/p/go #

Patch Set 2 : diff -r fa39a7dac971 https://code.google.com/p/go #

Patch Set 3 : diff -r fa39a7dac971 https://code.google.com/p/go #

Patch Set 4 : diff -r fa39a7dac971 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -4 lines) Patch
M src/pkg/encoding/gob/encode.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/encoding/gob/gobencdec_test.go View 1 2 3 2 chunks +16 lines, -3 lines 0 comments Download

Messages

Total messages: 5
jonallie
Hello golang-codereviews@googlegroups.com (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
9 years, 11 months ago (2014-04-26 05:11:58 UTC) #1
r
looks nice and simple but needs a test.
9 years, 11 months ago (2014-04-26 14:29:55 UTC) #2
jonallie
On 2014/04/26 14:29:55, r wrote: > looks nice and simple but needs a test. Added ...
9 years, 11 months ago (2014-04-26 16:22:48 UTC) #3
r
LGTM
9 years, 11 months ago (2014-04-26 16:24:25 UTC) #4
r
9 years, 11 months ago (2014-04-26 16:25:19 UTC) #5
*** Submitted as https://code.google.com/p/go/source/detail?r=aefa5032b453 ***

      encoding/gob: handle interface types in isZero() by returning true for nil
interfaces.

Fixes issue 7741.

LGTM=r
R=golang-codereviews, r
CC=golang-codereviews
https://codereview.appspot.com/96830044

Committer: Rob Pike <r@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b