Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(527)

Issue 9681044: code review 9681044: cmd/cov: delete (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 10 months ago by r
Modified:
11 years, 10 months ago
Reviewers:
dave, rsc, bradfitz
CC:
golang-dev, bradfitz, dave_cheney.net, rsc
Visibility:
Public.

Description

cmd/cov: delete It doesn't work, it's not portable, it's not part of the released binaries, and a better tool is due. Fixes issue 1319. Fixes issue 4621.

Patch Set 1 #

Patch Set 2 : diff -r 2c6762d33112 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -825 lines) Patch
R src/cmd/cov/Makefile View 1 chunk +0 lines, -5 lines 0 comments Download
R src/cmd/cov/doc.go View 1 chunk +0 lines, -36 lines 0 comments Download
R src/cmd/cov/main.c View 1 chunk +0 lines, -484 lines 0 comments Download
R src/cmd/cov/tree.h View 1 chunk +0 lines, -47 lines 0 comments Download
R src/cmd/cov/tree.c View 1 chunk +0 lines, -245 lines 0 comments Download
M src/cmd/dist/build.c View 5 chunks +3 lines, -6 lines 0 comments Download
M src/sudo.bash View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7
r
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/
11 years, 10 months ago (2013-05-23 23:27:51 UTC) #1
bradfitz
LGTM On Thu, May 23, 2013 at 4:27 PM, <r@golang.org> wrote: > Reviewers: golang-dev1, > ...
11 years, 10 months ago (2013-05-23 23:36:33 UTC) #2
dave_cheney.net
LGTM. Possibly make reference to https://code.google.com/p/go/issues/detail?id=4621 On Fri, May 24, 2013 at 9:36 AM, Brad ...
11 years, 10 months ago (2013-05-23 23:37:44 UTC) #3
r
Added references to 1319 and 4621.
11 years, 10 months ago (2013-05-23 23:44:11 UTC) #4
dave_cheney.net
On 2013/05/23 23:44:11, r wrote: > Added references to 1319 and 4621. Fire when ready.
11 years, 10 months ago (2013-05-23 23:45:20 UTC) #5
rsc
LGTM
11 years, 10 months ago (2013-05-24 18:04:17 UTC) #6
r
11 years, 10 months ago (2013-05-24 18:06:09 UTC) #7
*** Submitted as https://code.google.com/p/go/source/detail?r=69000c52c3ab ***

cmd/cov: delete
It doesn't work, it's not portable, it's not part of the released
binaries, and a better tool is due.

Fixes issue 1319.
Fixes issue 4621.

R=golang-dev, bradfitz, dave, rsc
CC=golang-dev
https://codereview.appspot.com/9681044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b