Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(82)

Issue 9679044: code review 9679044: go.talks: inline the reader package in each main, (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 10 months ago by Sameer Ajmani
Modified:
9 years, 4 months ago
Reviewers:
adg, gri
CC:
adg, golang-dev
Visibility:
Public.

Description

go.talks: inline the reader package in each main, since playground doesn't currently handle packages in other directories. Move the real implementation to a separate realmain.go, so that the talk examples don't depend on the external rss package. Update the slides to reference fakemain.go.

Patch Set 1 #

Patch Set 2 : diff -r b21fcde83af7 https://code.google.com/p/go.talks #

Patch Set 3 : diff -r b21fcde83af7 https://code.google.com/p/go.talks #

Total comments: 2

Patch Set 4 : diff -r b21fcde83af7 https://code.google.com/p/go.talks #

Patch Set 5 : diff -r b21fcde83af7 https://code.google.com/p/go.talks #

Patch Set 6 : diff -r b21fcde83af7 https://code.google.com/p/go.talks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2495 lines, -1016 lines) Patch
M 2013/advconc.slide View 1 2 3 4 5 10 chunks +31 lines, -37 lines 0 comments Download
R 2013/advconc/buffer.go View 1 2 3 4 5 1 chunk +0 lines, -43 lines 0 comments Download
A 2013/advconc/buffer/buffer.go View 1 2 3 4 5 1 chunk +43 lines, -0 lines 0 comments Download
R 2013/advconc/dedupermain.go View 1 2 3 4 5 1 chunk +0 lines, -41 lines 0 comments Download
A 2013/advconc/dedupermain/dedupermain.go View 1 2 3 4 1 chunk +549 lines, -0 lines 0 comments Download
R 2013/advconc/fakemain.go View 1 2 3 4 5 1 chunk +0 lines, -39 lines 0 comments Download
A 2013/advconc/fakemain/fakemain.go View 1 2 3 4 1 chunk +546 lines, -0 lines 0 comments Download
R 2013/advconc/fakemainnomerge.go View 1 2 3 4 5 1 chunk +0 lines, -33 lines 0 comments Download
R 2013/advconc/naivemain.go View 1 2 3 4 5 1 chunk +0 lines, -85 lines 0 comments Download
A 2013/advconc/naivemain/naivemain.go View 1 2 3 4 1 chunk +593 lines, -0 lines 0 comments Download
R 2013/advconc/naivemainnomerge.go View 1 2 3 4 5 1 chunk +0 lines, -30 lines 0 comments Download
R 2013/advconc/nilselect.go View 1 2 3 4 5 1 chunk +0 lines, -30 lines 0 comments Download
A 2013/advconc/nilselect/nilselect.go View 1 2 3 4 5 1 chunk +30 lines, -0 lines 0 comments Download
A 2013/advconc/pingpong/pingpong.go View 1 2 3 4 5 1 chunk +31 lines, -0 lines 0 comments Download
R 2013/advconc/pingpong2.go View 1 2 3 4 5 1 chunk +0 lines, -42 lines 0 comments Download
R 2013/advconc/pingpongdeadlock.go View 1 2 3 4 5 1 chunk +0 lines, -31 lines 0 comments Download
A 2013/advconc/pingpongdeadlock/pingpongdeadlock.go View 1 2 3 4 5 1 chunk +31 lines, -0 lines 0 comments Download
R 2013/advconc/pingpongpanic.go View 1 2 3 4 5 1 chunk +0 lines, -33 lines 0 comments Download
A 2013/advconc/pingpongpanic/pingpongpanic.go View 1 2 3 4 5 1 chunk +33 lines, -0 lines 0 comments Download
R 2013/advconc/reader/reader.go View 1 2 3 5 1 chunk +0 lines, -572 lines 0 comments Download
A 2013/advconc/realmain/realmain.go View 1 2 3 4 1 chunk +608 lines, -0 lines 0 comments Download

Messages

Total messages: 11
Sameer Ajmani
Hello adg (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.talks
10 years, 10 months ago (2013-05-23 01:29:22 UTC) #1
adg
https://codereview.appspot.com/9679044/diff/5001/2013/advconc/reader/reader.go File 2013/advconc/reader/reader.go (right): https://codereview.appspot.com/9679044/diff/5001/2013/advconc/reader/reader.go#newcode1 2013/advconc/reader/reader.go:1: import rss "github.com/jteeuwen/go-pkg-rss" this is no longer a valid ...
10 years, 10 months ago (2013-05-23 01:43:30 UTC) #2
Sameer Ajmani
https://codereview.appspot.com/9679044/diff/5001/2013/advconc/reader/reader.go File 2013/advconc/reader/reader.go (right): https://codereview.appspot.com/9679044/diff/5001/2013/advconc/reader/reader.go#newcode1 2013/advconc/reader/reader.go:1: import rss "github.com/jteeuwen/go-pkg-rss" On 2013/05/23 01:43:31, adg wrote: > ...
10 years, 10 months ago (2013-05-23 02:32:50 UTC) #3
adg
On 23 May 2013 12:32, <sameer@golang.org> wrote: > But I realize now that the playground ...
10 years, 10 months ago (2013-05-23 02:37:43 UTC) #4
Sameer Ajmani
Done, thanks. On 2013/05/23 02:37:43, adg wrote: > On 23 May 2013 12:32, <mailto:sameer@golang.org> wrote: ...
10 years, 10 months ago (2013-05-23 02:55:08 UTC) #5
adg
Looking good. Now you can fix the build by putting each .go program in a ...
10 years, 10 months ago (2013-05-23 03:24:09 UTC) #6
Sameer Ajmani
Done. On 2013/05/23 03:24:09, adg wrote: > Looking good. Now you can fix the build ...
10 years, 10 months ago (2013-05-23 15:43:39 UTC) #7
adg
LGTM Thanks!
10 years, 10 months ago (2013-05-23 23:32:20 UTC) #8
adg
*** Submitted as https://code.google.com/p/go/source/detail?r=9b0d52b06893&repo=talks *** go.talks: inline the reader package in each main, since playground ...
10 years, 10 months ago (2013-05-23 23:33:07 UTC) #9
gri
This CL appears to have broken the go.talks build.
10 years, 10 months ago (2013-05-25 17:26:44 UTC) #10
adg
10 years, 10 months ago (2013-05-25 23:19:05 UTC) #11
On 26 May 2013 03:26, <gri@golang.org> wrote:

> This CL appears to have broken the go.talks build.


It was already broken.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b