Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(445)

Issue 96690043: code review 96690043: [release-branch.go1.3] time: support version 3 zone records (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 10 months ago by dsymonds
Modified:
9 years, 10 months ago
Reviewers:
gobot, rsc
CC:
adg, rsc, golang-codereviews
Visibility:
Public.

Description

[release-branch.go1.3] time: support version 3 zone records ««« CL 100930044 / fde405c62fca time: support version 3 zone records Fixes Issue 8134 LGTM=iant R=golang-codereviews, iant CC=golang-codereviews, r, rsc https://codereview.appspot.com/100930044 »»»

Patch Set 1 #

Patch Set 2 : diff -r 1fd4196d2751 https://code.google.com/p/go #

Patch Set 3 : diff -r 1fd4196d2751 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -2 lines) Patch
M src/pkg/time/zoneinfo_read.go View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/pkg/time/zoneinfo_test.go View 1 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 4
dsymonds
Hello adg, rsc (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
9 years, 10 months ago (2014-06-03 05:59:57 UTC) #1
rsc
LGTM
9 years, 10 months ago (2014-06-03 06:12:26 UTC) #2
dsymonds
*** Submitted as https://code.google.com/p/go/source/detail?r=eee406e46a11 *** [release-branch.go1.3] time: support version 3 zone records ««« CL 100930044 ...
9 years, 10 months ago (2014-06-03 06:13:45 UTC) #3
gobot
9 years, 10 months ago (2014-06-03 06:34:45 UTC) #4
Message was sent while issue was closed.
This CL appears to have broken the nacl-amd64p32 builder.
See http://build.golang.org/log/4c8f4b42ba21de4cf44e1fc5b138b59e39a71310
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b