Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(510)

Issue 96680045: code review 96680045: debug/elf: support DWARF that needs relocs for 386 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 9 months ago by iant
Modified:
10 years, 9 months ago
Reviewers:
rsc
CC:
golang-codereviews, bradfitz, rsc
Visibility:
Public.

Description

debug/elf: support DWARF that needs relocs for 386 It's not clear how widespread this issue is, but we do have a test case generated by a development version of clang. I don't know whether this should go into 1.3 or not; happy to hear arguments either way.

Patch Set 1 #

Total comments: 2

Patch Set 2 : diff -r 318b56ffe04b https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -2 lines) Patch
M src/pkg/debug/elf/file.go View 3 chunks +56 lines, -2 lines 0 comments Download
M src/pkg/debug/elf/file_test.go View 1 chunk +6 lines, -0 lines 0 comments Download
A src/pkg/debug/elf/testdata/go-relocation-test-clang-x86.obj View Binary file 0 comments Download

Messages

Total messages: 7
iant
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
10 years, 9 months ago (2014-06-03 00:57:24 UTC) #1
bradfitz
https://codereview.appspot.com/96680045/diff/1/src/pkg/debug/elf/file.go File src/pkg/debug/elf/file.go (right): https://codereview.appspot.com/96680045/diff/1/src/pkg/debug/elf/file.go#newcode592 src/pkg/debug/elf/file.go:592: binary.Read(b, f.ByteOrder, &rel) check error? if rels is short ...
10 years, 9 months ago (2014-06-03 01:09:37 UTC) #2
iant
https://codereview.appspot.com/96680045/diff/1/src/pkg/debug/elf/file.go File src/pkg/debug/elf/file.go (right): https://codereview.appspot.com/96680045/diff/1/src/pkg/debug/elf/file.go#newcode592 src/pkg/debug/elf/file.go:592: binary.Read(b, f.ByteOrder, &rel) On 2014/06/03 01:09:36, bradfitz wrote: > ...
10 years, 9 months ago (2014-06-03 01:26:15 UTC) #3
rsc
LGTM This is fine to go into 1.3. What's broken? This is the elf reader ...
10 years, 9 months ago (2014-06-03 22:44:28 UTC) #4
iant
On 2014/06/03 22:44:28, rsc wrote: > > What's broken? This is the elf reader not ...
10 years, 9 months ago (2014-06-03 23:36:55 UTC) #5
iant
*** Submitted as https://code.google.com/p/go/source/detail?r=5439c77d4acb *** debug/elf: support DWARF that needs relocs for 386 It's not ...
10 years, 9 months ago (2014-06-03 23:39:43 UTC) #6
rsc
10 years, 9 months ago (2014-06-03 23:40:13 UTC) #7
Thanks. I always forget that cgo uses this.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b