Issue 96650043: code review 96650043: go-tour: add solution for HTTP exercise

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 96650043: code review 96650043: go-tour: add solution for HTTP exercise (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 11 months ago by adg

Modified:
9 years, 11 months ago

Reviewers:
minux1

CC:
golang-codereviews, minux1, mikio

Visibility:
Public.

Description

go-tour: add solution for HTTP exercise Fixes issue 176.

Patch Set 1 #

Patch Set 2 : diff -r 27fad7d05796 https://code.google.com/p/go-tour #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+38 lines, -0 lines)			Patch
	A	solutions/http.go	View		1 chunk	+38 lines, -0 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

adg

Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go-tour

9 years, 11 months ago (2014-05-30 02:42:17 UTC) #1

minux1

On May 29, 2014 8:08 PM, "Mikio Hara" <mikioh.mikioh@gmail.com> wrote: > > Fixes issue 176. ...

9 years, 11 months ago (2014-05-30 03:26:13 UTC) #4

mikio

On Fri, May 30, 2014 at 12:26 PM, minux <minux.ma@gmail.com> wrote: >> 176? > this ...

9 years, 11 months ago (2014-05-30 03:32:11 UTC) #5

adg

9 years, 11 months ago (2014-05-30 03:53:26 UTC) #6

*** Submitted as https://code.google.com/p/go-tour/source/detail?r=7394a5d4afce
***

go-tour: add solution for HTTP exercise

Fixes issue 176.

LGTM=minux.ma
R=golang-codereviews, minux.ma, mikioh.mikioh
CC=golang-codereviews
https://codereview.appspot.com/96650043

Expand All Messages | Collapse All Messages