Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(35)

Issue 9649045: code review 9649045: cmd/cgo: using __typeof__(a->r) instead of putting inva... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 10 months ago by minux1
Modified:
10 years, 10 months ago
Reviewers:
iant
CC:
golang-dev, iant
Visibility:
Public.

Description

cmd/cgo: using __typeof__(a->r) instead of putting invalid TYPE in "a->r = (const TYPE)" Thanks kballard for the hint. Fixes issue 4857.

Patch Set 1 #

Patch Set 2 : diff -r 41702da0dcc4 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 41702da0dcc4 https://code.google.com/p/go/ #

Patch Set 4 : diff -r 41702da0dcc4 https://code.google.com/p/go/ #

Total comments: 1

Patch Set 5 : diff -r f9e22f8aa00d https://code.google.com/p/go/ #

Patch Set 6 : diff -r f9e22f8aa00d https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -1 line) Patch
A misc/cgo/test/issue4857.go View 1 1 chunk +15 lines, -0 lines 0 comments Download
M src/cmd/cgo/out.go View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
minux1
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/
10 years, 10 months ago (2013-05-29 22:42:40 UTC) #1
iant
LGTM Thanks. https://codereview.appspot.com/9649045/diff/8001/src/cmd/cgo/out.go File src/cmd/cgo/out.go (right): https://codereview.appspot.com/9649045/diff/8001/src/cmd/cgo/out.go#newcode493 src/cmd/cgo/out.go:493: fmt.Fprint(fgcc, "(const __typeof__(a->r)) ") Remove the "const" ...
10 years, 10 months ago (2013-05-31 14:27:42 UTC) #2
minux1
10 years, 10 months ago (2013-06-02 14:47:10 UTC) #3
*** Submitted as https://code.google.com/p/go/source/detail?r=c0c4cf119f9b ***

cmd/cgo: using __typeof__(a->r) instead of putting invalid TYPE in "a->r =
(const TYPE)"
Thanks kballard for the hint.
Fixes issue 4857.

R=golang-dev, iant
CC=golang-dev
https://codereview.appspot.com/9649045
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b