Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(73)

Issue 96300045: code review 96300045: cmd/cgo: omit misaligned struct fields, like we omit bi... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 10 months ago by rsc
Modified:
9 years, 10 months ago
Reviewers:
gobot, iant
CC:
golang-codereviews, iant
Visibility:
Public.

Description

cmd/cgo: omit misaligned struct fields, like we omit bitfields Fixes issue 7560.

Patch Set 1 #

Patch Set 2 : diff -r 0f7c69d6c367 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 0f7c69d6c367 https://code.google.com/p/go/ #

Patch Set 4 : diff -r 63e42cda1b99 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -3 lines) Patch
M misc/cgo/test/cgo_test.go View 1 1 chunk +1 line, -0 lines 0 comments Download
A misc/cgo/test/issue7560.go View 1 1 chunk +44 lines, -0 lines 0 comments Download
M src/cmd/cgo/doc.go View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M src/cmd/cgo/gcc.go View 1 3 chunks +12 lines, -3 lines 0 comments Download

Messages

Total messages: 4
rsc
Hello golang-codereviews@googlegroups.com (cc: iant), I'd like you to review this change to https://code.google.com/p/go/
9 years, 10 months ago (2014-05-13 02:48:10 UTC) #1
iant
LGTM
9 years, 10 months ago (2014-05-13 03:18:14 UTC) #2
rsc
*** Submitted as https://code.google.com/p/go/source/detail?r=2fb7165d5fdc *** cmd/cgo: omit misaligned struct fields, like we omit bitfields Fixes ...
9 years, 10 months ago (2014-05-13 03:48:21 UTC) #3
gobot
9 years, 10 months ago (2014-05-13 04:53:19 UTC) #4
Message was sent while issue was closed.
This CL appears to have broken the linux-arm-cheney-imx6 builder.
See http://build.golang.org/log/59ba08e9ace263983c866bfd5d778ee5c484d5bf
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b