Issue 9627043: code review 9627043: net/http: don't send Accept-Encoding on HEAD requests

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 9627043: code review 9627043: net/http: don't send Accept-Encoding on HEAD requests (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 11 months ago by bradfitz

Modified:
10 years, 11 months ago

Reviewers:
iant

CC:
iant, gobot, golang-dev

Visibility:
Public.

Description

net/http: don't send Accept-Encoding on HEAD requests Works around a bug in nginx: http://trac.nginx.org/nginx/ticket/358 Fixes Issue 5522

Patch Set 2 : diff -r cd75cc2f6871 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r cd75cc2f6871 https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 4 : diff -r 26ed0c032256 https://go.googlecode.com/hg/ #

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -4 lines)			Patch
	M	src/pkg/net/http/transport.go	View	1	1 chunk	+6 lines, -1 line	0 comments	Download
	M	src/pkg/net/http/transport_test.go	View	1 2 3	1 chunk	+6 lines, -3 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

bradfitz

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

10 years, 11 months ago (2013-05-21 21:31:31 UTC) #1

iant

LGTM https://codereview.appspot.com/9627043/diff/5001/src/pkg/net/http/transport_test.go File src/pkg/net/http/transport_test.go (right): https://codereview.appspot.com/9627043/diff/5001/src/pkg/net/http/transport_test.go#newcode598 src/pkg/net/http/transport_test.go:598: if req.Method == "HEAD" { Seems like you ...

10 years, 11 months ago (2013-05-21 22:13:01 UTC) #3

bradfitz

10 years, 11 months ago (2013-05-21 22:21:39 UTC) #4

*** Submitted as https://code.google.com/p/go/source/detail?r=78e5ea623996 ***

net/http: don't send Accept-Encoding on HEAD requests

Works around a bug in nginx: http://trac.nginx.org/nginx/ticket/358

Fixes Issue 5522

R=iant
CC=gobot, golang-dev
https://codereview.appspot.com/9627043

Expand All Messages | Collapse All Messages