Issue 96240043: code review 96240043: go.crypto/openpgp: fix user id signing.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 96240043: code review 96240043: go.crypto/openpgp: fix user id signing. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 11 months ago by agl1

Modified:
9 years, 11 months ago

Reviewers:
bradfitz

CC:
bradfitz, golang-codereviews

Visibility:
Public.

Description

go.crypto/openpgp: fix user id signing. Entity.SignIdentity used the wrong signature function and produced invalid certification signatures. Fixed. VerifyUserIdSignature was used for checking the self-signature on an identity, but didn't support anything but a self-signature. This change alters the low-level API so that checking cross-signatures is possible. Fixes issue 7371.

Patch Set 1 #

Patch Set 2 : diff -r fe6c00a82e55 https://code.google.com/p/go.crypto/ #

Patch Set 3 : diff -r fe6c00a82e55 https://code.google.com/p/go.crypto/ #

Patch Set 4 : diff -r 9e4982062c72 https://code.google.com/p/go.crypto #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+48 lines, -12 lines)			Patch
M	openpgp/keys.go	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	openpgp/keys_test.go	View	1	1 chunk	+36 lines, -0 lines	0 comments	Download
M	openpgp/packet/public_key.go	View	1	2 chunks	+6 lines, -6 lines	0 comments	Download
M	openpgp/packet/public_key_test.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	openpgp/packet/public_key_v3.go	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	openpgp/packet/signature.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

agl1

Hello bradfitz@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.crypto/

9 years, 11 months ago (2014-05-12 02:35:22 UTC) #1

agl1

9 years, 11 months ago (2014-05-12 18:23:55 UTC) #3

*** Submitted as
https://code.google.com/p/go/source/detail?r=d88182750244&repo=crypto ***

go.crypto/openpgp: fix user id signing.

Entity.SignIdentity used the wrong signature function and produced invalid
certification signatures. Fixed.

VerifyUserIdSignature was used for checking the self-signature on an identity,
but didn't support anything but a self-signature. This change alters the
low-level API so that checking cross-signatures is possible.

Fixes issue 7371.

LGTM=bradfitz
R=bradfitz
CC=golang-codereviews
https://codereview.appspot.com/96240043

Expand All Messages | Collapse All Messages