Issue 96230044: code review 96230044: net/http_test: prevent idle transport on race condition

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 96230044: code review 96230044: net/http_test: prevent idle transport on race condition

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 12 months ago by fabmilo

Modified:
9 years, 12 months ago

Reviewers:
bradfitz

CC:
golang-codereviews, bradfitz

Visibility:
Public.

Description

net/http_test: prevent idle transport on race condition Fixes issue 7847

Patch Set 1 #

Patch Set 2 : diff -r 299229ac4300 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 299229ac4300 https://code.google.com/p/go/ #

Patch Set 4 : diff -r 299229ac4300 https://code.google.com/p/go/ #

Patch Set 5 : diff -r 299229ac4300 https://code.google.com/p/go/ #

Created: 9 years, 12 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -3 lines)			Patch
	M	src/pkg/net/http/transport_test.go	View	1	2 chunks	+5 lines, -3 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

fabmilo

Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/

9 years, 12 months ago (2014-05-11 17:28:41 UTC) #1

bradfitz

9 years, 12 months ago (2014-05-12 16:37:44 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=5283a606b755 ***

net/http: fix flaky test

Prevent idle transport on race condition.

Fixes issue 7847

LGTM=bradfitz
R=golang-codereviews, bradfitz
CC=golang-codereviews
https://codereview.appspot.com/96230044

Committer: Brad Fitzpatrick <bradfitz@golang.org>

Expand All Messages | Collapse All Messages