Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1113)

Issue 96060043: code review 96060043: runtime: fix bug in cpu profiler (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 10 months ago by dvyukov
Modified:
9 years, 10 months ago
Reviewers:
gobot, rsc, iant
CC:
golang-codereviews, iant, rsc
Visibility:
Public.

Description

runtime: fix bug in cpu profiler Number of lost samples was overcounted (never reset). Also remove unused variable (it's trivial to restore it for debugging if needed).

Patch Set 1 #

Patch Set 2 : diff -r d797b2316601 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 3 : diff -r d797b2316601 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 4 : diff -r 0d029f2ef377 https://dvyukov%40google.com@code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M src/pkg/runtime/cpuprof.goc View 1 3 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 5
dvyukov
Hello golang-codereviews@googlegroups.com (cc: iant@golang.org, rsc@golang.org), I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/
9 years, 10 months ago (2014-05-07 09:06:46 UTC) #1
iant
LGTM
9 years, 10 months ago (2014-05-07 13:28:06 UTC) #2
dvyukov
*** Submitted as https://code.google.com/p/go/source/detail?r=0a14878cbb60 *** runtime: fix bug in cpu profiler Number of lost samples ...
9 years, 10 months ago (2014-05-07 14:48:30 UTC) #3
gobot
This CL appears to have broken the linux-386-387 builder. See http://build.golang.org/log/5019a2f96df445d3c7516b79eca80f61b8d066a4
9 years, 10 months ago (2014-05-07 14:49:19 UTC) #4
rsc
9 years, 10 months ago (2014-05-07 15:07:04 UTC) #5
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b