Issue 95560048: code review 95560048: go.net/ipv4: add stubs for nacl build

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 95560048: code review 95560048: go.net/ipv4: add stubs for nacl build (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 10 months ago by mikio

Modified:
10 years, 10 months ago

Reviewers:
iant

CC:
golang-codereviews, iant

Visibility:
Public.

Description

go.net/ipv4: add stubs for nacl build

Patch Set 1 #

Patch Set 2 : diff -r b50b86678674 https://code.google.com/p/go.net #

Patch Set 3 : diff -r b50b86678674 https://code.google.com/p/go.net #

Patch Set 4 : diff -r b50b86678674 https://code.google.com/p/go.net #

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -5 lines)			Patch
M	ipv4/control_stub.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	ipv4/dgramopt_stub.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	ipv4/genericopt_stub.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	ipv4/helper_stub.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	ipv4/sockopt_stub.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

mikio

Hello golang-codereviews@googlegroups.com (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.net

10 years, 10 months ago (2014-05-21 00:15:06 UTC) #1

mikio

10 years, 10 months ago (2014-05-21 00:27:55 UTC) #3

*** Submitted as
https://code.google.com/p/go/source/detail?r=4b295625c8fb&repo=net ***

go.net/ipv4: add stubs for nacl build

LGTM=iant
R=golang-codereviews, iant
CC=golang-codereviews
https://codereview.appspot.com/95560048

Expand All Messages | Collapse All Messages