code review 9543043: database/sql: remove extra RemoveDep call

database/sql: remove extra RemoveDep call

This should have been removed in 45c12efb4635. Not a correctness
issue, but unnecessary work.

This CL also adds paranoia checks in removeDep so this doesn't
happen again.

Fixes Issue 5502

[bradfitz, 2013-05-18 20:54:51]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[julienschmidt, 2013-05-18 23:47:31]

https://codereview.appspot.com/9543043/diff/3003/src/pkg/database/sql/sql.go
File src/pkg/database/sql/sql.go (right):

https://codereview.appspot.com/9543043/diff/3003/src/pkg/database/sql/sql.go#...
src/pkg/database/sql/sql.go:372: panic(fmt.Sprintf("unpaired removeDep: no %T
dep on %T", dep, x))
Do you really think it is a good idea to panic in such a case?
Calling delete once more than possible is not really harmful, but a panic is.
This is great for debugging, but what if this case occurs in a release version?

[julienschmidt, 2013-05-18 23:48:59]

Um.. once more than "necessary"... not "possible". Enough code for today.
On 2013/05/18 23:47:31, julienschmidt wrote:
> https://codereview.appspot.com/9543043/diff/3003/src/pkg/database/sql/sql.go
> File src/pkg/database/sql/sql.go (right):
> 
>
https://codereview.appspot.com/9543043/diff/3003/src/pkg/database/sql/sql.go#...
> src/pkg/database/sql/sql.go:372: panic(fmt.Sprintf("unpaired removeDep: no %T
> dep on %T", dep, x))
> Do you really think it is a good idea to panic in such a case?
> Calling delete once more than possible is not really harmful, but a panic is.
> This is great for debugging, but what if this case occurs in a release
version?

[gobot, 2013-05-21 15:37:27]

R=adg (assigned by bradfitz)

[adg, 2013-05-21 21:52:51]

LGTM

https://codereview.appspot.com/9543043/diff/3003/src/pkg/database/sql/sql.go
File src/pkg/database/sql/sql.go (right):

https://codereview.appspot.com/9543043/diff/3003/src/pkg/database/sql/sql.go#...
src/pkg/database/sql/sql.go:366: l0 := len(xdep)
l0 looks exactly like 10 on my screen :|

[bradfitz, 2013-05-21 21:58:11]

*** Submitted as https://code.google.com/p/go/source/detail?r=26ed0c032256 ***

database/sql: remove extra RemoveDep call

This should have been removed in 45c12efb4635. Not a correctness
issue, but unnecessary work.

This CL also adds paranoia checks in removeDep so this doesn't
happen again.

Fixes Issue 5502

R=adg
CC=gobot, golang-dev, google
https://codereview.appspot.com/9543043