code review 952041: json: streaming

json: streaming

[rsc, 2010-04-27 09:12:50]

Hello r (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[rsc, 2010-04-27 09:14:23]

Sorry for the code review storm.

This is the last one necessary to finish off the
JSON refinements for the new JSON RPC code.

Tomorrow I'll fix up the names in the rpc CL
and then send the actual rpc/jsonrpc package.

Russ

[cw, 2010-04-27 09:21:45]

Very nice, it looks very much like the gob APIs at this point.

http://codereview.appspot.com/952041/diff/2001/3002
File src/pkg/json/stream.go (right):

http://codereview.appspot.com/952041/diff/2001/3002#newcode176
src/pkg/json/stream.go:176: func (m *RawMessage) UnmarshalJSON(data []byte)
os.Error {
The JSON suffix here seems unnecessary, it doesn't look like it's needed to
avoid a collision in this case?

[r, 2010-04-27 16:50:09]

LGTM

this stuff is starting to feel right

http://codereview.appspot.com/952041/diff/2001/3002
File src/pkg/json/stream.go (right):

http://codereview.appspot.com/952041/diff/2001/3002#newcode28
src/pkg/json/stream.go:28: // connection and stores it in the value pointed at
by v.
s/at/to/

[rsc, 2010-04-27 17:18:26]

> http://codereview.appspot.com/952041/diff/2001/3002#newcode176
> src/pkg/json/stream.go:176: func (m *RawMessage) UnmarshalJSON(data
> []byte) os.Error {
> The JSON suffix here seems unnecessary, it doesn't look like it's needed
> to avoid a collision in this case?

It is necessary to satisfy the json.Unmarshaler interface,
and there the method is named UnmarshalJSON so that
a single type can implement multiple kinds of Unmarshal
methods.

[rsc, 2010-04-27 17:46:40]

*** Submitted as http://code.google.com/p/go/source/detail?r=80df82b4fd8b ***

json: streaming

R=r, cw
CC=golang-dev
http://codereview.appspot.com/952041

[cw, 2010-04-27 18:36:43]

curiouser and curiouser

http://codereview.appspot.com/952041/diff/11001/12002
File src/pkg/json/stream.go (right):

http://codereview.appspot.com/952041/diff/11001/12002#newcode185
src/pkg/json/stream.go:185: var _ Unmarshaler = (*RawMessage)(nil)
compile time checking for something?

does gc optimize this out?

[rsc, 2010-04-27 18:38:47]

> http://codereview.appspot.com/952041/diff/11001/12002#newcode185
> src/pkg/json/stream.go:185: var _ Unmarshaler = (*RawMessage)(nil)
> compile time checking for something?
>
> does gc optimize this out?

type checking that statement makes sure that
*RawMessage satisfies Unmarshaler.

and yes.