Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(9568)

Issue 9517047: code review 9517047: go.talks: fix Advanced Concurrency Patterns imports (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 11 months ago by adg
Modified:
10 years, 11 months ago
Reviewers:
dave
CC:
golang-dev, dave_cheney.net
Visibility:
Public.

Description

go.talks: fix Advanced Concurrency Patterns imports Doesn't fix the build, but at least makes the programs correct.

Patch Set 1 #

Patch Set 2 : diff -r 1eecbdc1a1fc https://code.google.com/p/go.talks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M 2013/advconc/dedupermain.go View 1 chunk +1 line, -1 line 0 comments Download
M 2013/advconc/fakemain.go View 1 chunk +1 line, -1 line 0 comments Download
M 2013/advconc/fakemainnomerge.go View 1 chunk +1 line, -1 line 0 comments Download
M 2013/advconc/naivemain.go View 1 chunk +1 line, -1 line 0 comments Download
M 2013/advconc/naivemainnomerge.go View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
adg
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go.talks
10 years, 11 months ago (2013-05-22 00:02:54 UTC) #1
dave_cheney.net
LGTM. I'm looking into the build failures and will raise an issue when the cause ...
10 years, 11 months ago (2013-05-22 00:05:44 UTC) #2
adg
10 years, 11 months ago (2013-05-22 00:10:36 UTC) #3
*** Submitted as
https://code.google.com/p/go/source/detail?r=676bb70b94b2&repo=talks ***

go.talks: fix Advanced Concurrency Patterns imports

Doesn't fix the build, but at least makes the programs correct.

R=golang-dev, dave
CC=golang-dev
https://codereview.appspot.com/9517047
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b