Issue 95060043: code review 95060043: net/mail: propagate unsupported charset error

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 95060043: code review 95060043: net/mail: propagate unsupported charset error (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 11 months ago by crawshaw

Modified:
9 years, 11 months ago

Reviewers:
iant

CC:
golang-codereviews, iant

Visibility:
Public.

Description

net/mail: propagate unsupported charset error Fixes Issue 6807.

Patch Set 1 #

Patch Set 2 : diff -r 7dc82eaef884 https://code.google.com/p/go #

Patch Set 3 : diff -r 7dc82eaef884 https://code.google.com/p/go #

Patch Set 4 : diff -r 7dc82eaef884 https://code.google.com/p/go #

Patch Set 5 : diff -r f96d3354edb6 https://code.google.com/p/go #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -4 lines)			Patch
	M	src/pkg/net/mail/message.go	View	1 2	3 chunks	+4 lines, -4 lines	0 comments	Download
	M	src/pkg/net/mail/message_test.go	View	1 2	2 chunks	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

crawshaw

Hello golang-codereviews@googlegroups.com (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

9 years, 11 months ago (2014-05-07 01:57:05 UTC) #1

crawshaw

9 years, 11 months ago (2014-05-07 09:58:45 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=0d029f2ef377 ***

net/mail: propagate unsupported charset error

Fixes Issue 6807.

LGTM=iant
R=golang-codereviews, iant
CC=golang-codereviews
https://codereview.appspot.com/95060043

Expand All Messages | Collapse All Messages