Issue 95030044: code review 95030044: go.tools/playground/socket: require origin to set up so...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 95030044: code review 95030044: go.tools/playground/socket: require origin to set up so... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 11 months ago by adg

Modified:
9 years, 11 months ago

Reviewers:
rsc

CC:
rsc, golang-codereviews

Visibility:
Public.

Description

go.tools/playground/socket: require origin to set up socket handler This prevents cross-site request forgery attacks.

Patch Set 1 #

Patch Set 2 : diff -r 90700ea62175 https://code.google.com/p/go.tools #

Patch Set 3 : diff -r df3cb6b735e4 https://code.google.com/p/go.tools #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -3 lines)			Patch
	M	playground/socket/socket.go	View	1	3 chunks	+26 lines, -3 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

adg

Hello rsc@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.tools

9 years, 11 months ago (2014-05-05 15:42:12 UTC) #2

adg

9 years, 11 months ago (2014-05-05 15:42:15 UTC) #3

*** Submitted as
https://code.google.com/p/go/source/detail?r=bda3619e7a2c&repo=tools ***

go.tools/playground/socket: require origin to set up socket handler

This prevents cross-site request forgery attacks.

LGTM=rsc
R=rsc
CC=golang-codereviews
https://codereview.appspot.com/95030044

Expand All Messages | Collapse All Messages