code review 9475043: misc/cgo/test: deflake TestParallelSleep once more

misc/cgo/test: deflake TestParallelSleep once more
Fixes issue 5480.

[minux1, 2013-05-17 15:01:31]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[minux1, 2013-05-17 15:07:27]

Tested on windows/{386,amd64}, linux/amd64 and netbsd/386.

Also verified that in rev 7e7ceffb8515 (the last commit before
the fix for issue 1560), the revised test still fails.

[iant, 2013-05-17 16:28:16]

LGTM

Nice.

[minux1, 2013-05-17 18:56:02]

*** Submitted as https://code.google.com/p/go/source/detail?r=c58a49d330d1 ***

misc/cgo/test: deflake TestParallelSleep once more
Fixes issue 5480.

R=golang-dev, iant
CC=golang-dev
https://codereview.appspot.com/9475043

[dave_cheney.net, 2013-05-17 19:02:51]

Once more unto the breach.

On Sat, May 18, 2013 at 4:56 AM,  <minux.ma@gmail.com> wrote:
> *** Submitted as
> https://code.google.com/p/go/source/detail?r=c58a49d330d1 ***
>
>
> misc/cgo/test: deflake TestParallelSleep once more
> Fixes issue 5480.
>
> R=golang-dev, iant
> CC=golang-dev
> https://codereview.appspot.com/9475043
>
>
>
> https://codereview.appspot.com/9475043/
>
> --
>
> ---You received this message because you are subscribed to the Google Groups
> "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-dev+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>
>

[minux1, 2013-05-17 19:06:54]

On Sat, May 18, 2013 at 3:02 AM, Dave Cheney <dave@cheney.net> wrote:

> Once more unto the breach.
>
As discussed on issue tracker (issue 5480), if this particular test still
is flaky,
we will skip it in short mode and make run.bash test ../misc/cgo/test with
-short.

[dave_cheney.net, 2013-05-17 19:08:05]

Agreed, thank you for stepping up and fixing this test (again) it is
arguably the most problematic we have.

On Sat, May 18, 2013 at 5:06 AM, minux <minux.ma@gmail.com> wrote:
>
> On Sat, May 18, 2013 at 3:02 AM, Dave Cheney <dave@cheney.net> wrote:
>>
>> Once more unto the breach.
>
> As discussed on issue tracker (issue 5480), if this particular test still is
> flaky,
> we will skip it in short mode and make run.bash test ../misc/cgo/test with
> -short.