Issue 9462049: code review 9462049: time: remove Time.FormatAppend

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 9462049: code review 9462049: time: remove Time.FormatAppend (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years ago by bradfitz

Modified:
11 years ago

Reviewers:
r

CC:
golang-dev

Visibility:
Public.

Description

time: remove Time.FormatAppend undo CL 8478044 / 0d28fd55e721 Lack of consensus. ««« original CL description time: add Time.FormatAppend This is a version of Time.Format that doesn't require allocation. Fixes Issue 5192 Update Issue 5195 R=r CC=gobot, golang-dev https://codereview.appspot.com/8478044 »»»

Patch Set 1 #

Patch Set 2 : diff -r cd75cc2f6871 https://go.googlecode.com/hg/ #

Created: 11 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -17 lines)			Patch
	M	src/pkg/time/format.go	View	1	3 chunks	+10 lines, -17 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

bradfitz

Hello r@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

11 years ago (2013-05-21 21:32:07 UTC) #1

bradfitz

*** Submitted as https://code.google.com/p/go/source/detail?r=547c4a0b2534 *** time: remove Time.FormatAppend undo CL 8478044 / 0d28fd55e721 Lack of ...

11 years ago (2013-05-21 21:32:11 UTC) #2

Message was sent while issue was closed.

LGTM

Expand All Messages | Collapse All Messages