Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(599)

Issue 9373046: code review 9373046: syscall: add IPv6 socket options for Unix variants (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 9 months ago by mikio
Modified:
11 years, 8 months ago
Reviewers:
dave, iant
CC:
golang-dev, dave_cheney.net, iant
Visibility:
Public.

Description

syscall: add IPv6 socket options for Unix variants This CL adds missing IPv6 socket options which are required to control IPv6 as described in RFC 3493, RFC 3542. Update issue 5538

Patch Set 1 : diff -r 2d4825868d95 https://code.google.com/p/go #

Patch Set 2 : diff -r 9d60132d7784 https://code.google.com/p/go #

Patch Set 3 : diff -r 45468e9eae1f https://code.google.com/p/go #

Patch Set 4 : diff -r a1fb1560e22e https://code.google.com/p/go #

Patch Set 5 : diff -r a1fb1560e22e https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+230 lines, -1 line) Patch
M src/pkg/syscall/mkerrors.sh View 3 chunks +4 lines, -1 line 0 comments Download
M src/pkg/syscall/syscall_bsd.go View 1 2 chunks +18 lines, -0 lines 0 comments Download
M src/pkg/syscall/syscall_linux.go View 1 2 chunks +17 lines, -0 lines 0 comments Download
M src/pkg/syscall/types_darwin.go View 1 2 3 chunks +7 lines, -0 lines 0 comments Download
M src/pkg/syscall/types_freebsd.go View 1 2 3 chunks +7 lines, -0 lines 0 comments Download
M src/pkg/syscall/types_linux.go View 1 2 3 chunks +7 lines, -0 lines 0 comments Download
M src/pkg/syscall/types_netbsd.go View 1 2 3 chunks +7 lines, -0 lines 0 comments Download
M src/pkg/syscall/types_openbsd.go View 1 2 3 chunks +7 lines, -0 lines 0 comments Download
M src/pkg/syscall/zerrors_darwin_386.go View 1 chunk +1 line, -0 lines 0 comments Download
M src/pkg/syscall/zerrors_darwin_amd64.go View 1 chunk +1 line, -0 lines 0 comments Download
M src/pkg/syscall/zerrors_freebsd_386.go View 1 chunk +1 line, -0 lines 0 comments Download
M src/pkg/syscall/zerrors_freebsd_amd64.go View 1 chunk +1 line, -0 lines 0 comments Download
M src/pkg/syscall/zerrors_freebsd_arm.go View 1 chunk +1 line, -0 lines 0 comments Download
M src/pkg/syscall/zerrors_linux_386.go View 1 chunk +1 line, -0 lines 0 comments Download
M src/pkg/syscall/zerrors_linux_amd64.go View 1 chunk +1 line, -0 lines 0 comments Download
M src/pkg/syscall/zerrors_linux_arm.go View 1 chunk +1 line, -0 lines 0 comments Download
M src/pkg/syscall/zerrors_netbsd_386.go View 1 chunk +1 line, -0 lines 0 comments Download
M src/pkg/syscall/zerrors_netbsd_amd64.go View 1 chunk +1 line, -0 lines 0 comments Download
M src/pkg/syscall/zerrors_netbsd_arm.go View 1 chunk +1 line, -0 lines 0 comments Download
M src/pkg/syscall/zerrors_openbsd_386.go View 1 chunk +1 line, -0 lines 0 comments Download
M src/pkg/syscall/zerrors_openbsd_amd64.go View 1 chunk +1 line, -0 lines 0 comments Download
M src/pkg/syscall/ztypes_darwin_386.go View 1 2 2 chunks +11 lines, -0 lines 0 comments Download
M src/pkg/syscall/ztypes_darwin_amd64.go View 1 2 2 chunks +11 lines, -0 lines 0 comments Download
M src/pkg/syscall/ztypes_freebsd_386.go View 1 2 2 chunks +11 lines, -0 lines 0 comments Download
M src/pkg/syscall/ztypes_freebsd_amd64.go View 1 2 2 chunks +11 lines, -0 lines 0 comments Download
M src/pkg/syscall/ztypes_freebsd_arm.go View 1 2 2 chunks +11 lines, -0 lines 0 comments Download
M src/pkg/syscall/ztypes_linux_386.go View 1 2 2 chunks +11 lines, -0 lines 0 comments Download
M src/pkg/syscall/ztypes_linux_amd64.go View 1 2 2 chunks +11 lines, -0 lines 0 comments Download
M src/pkg/syscall/ztypes_linux_arm.go View 1 2 2 chunks +11 lines, -0 lines 0 comments Download
M src/pkg/syscall/ztypes_netbsd_386.go View 1 2 2 chunks +11 lines, -0 lines 0 comments Download
M src/pkg/syscall/ztypes_netbsd_amd64.go View 1 2 2 chunks +11 lines, -0 lines 0 comments Download
M src/pkg/syscall/ztypes_netbsd_arm.go View 1 2 2 chunks +11 lines, -0 lines 0 comments Download
M src/pkg/syscall/ztypes_openbsd_386.go View 1 2 2 chunks +11 lines, -0 lines 0 comments Download
M src/pkg/syscall/ztypes_openbsd_amd64.go View 1 2 2 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 9
mikio
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
11 years, 9 months ago (2013-05-20 10:01:32 UTC) #1
dave_cheney.net
Hi Mikio, Going through this CL I see some unrelated removals of return values. For ...
11 years, 9 months ago (2013-05-20 11:54:46 UTC) #2
mikio
Hello golang-dev@googlegroups.com, dave@cheney.net (cc: golang-dev@googlegroups.com), Please take another look.
11 years, 9 months ago (2013-05-20 12:21:32 UTC) #3
dave_cheney.net
Is the Sizeoftimeval constant required ?
11 years, 9 months ago (2013-05-21 11:26:55 UTC) #4
mikio
> Is the Sizeoftimeval constant required ? overlooked, thx.
11 years, 9 months ago (2013-05-22 13:32:18 UTC) #5
mikio
Hello golang-dev@googlegroups.com, dave@cheney.net (cc: golang-dev@googlegroups.com), Please take another look.
11 years, 9 months ago (2013-05-22 13:33:13 UTC) #6
iant
LGTM
11 years, 8 months ago (2013-05-22 18:24:02 UTC) #7
dave_cheney.net
LGTM. Thank you. On 23/05/2013, at 4:24, iant@golang.org wrote: > LGTM > > https://codereview.appspot.com/9373046/
11 years, 8 months ago (2013-05-22 22:17:26 UTC) #8
mikio
11 years, 8 months ago (2013-05-23 07:22:16 UTC) #9
*** Submitted as https://code.google.com/p/go/source/detail?r=bb012ad2fa67 ***

syscall: add IPv6 socket options for Unix variants

This CL adds missing IPv6 socket options which are required
to control IPv6 as described in RFC 3493, RFC 3542.

Update issue 5538

R=golang-dev, dave, iant
CC=golang-dev
https://codereview.appspot.com/9373046
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b