Issue 93520045: code review 93520045: cmd/objdump: fix dissasembly of Plan 9 object files

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 93520045: code review 93520045: cmd/objdump: fix dissasembly of Plan 9 object files (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 11 months ago by ality

Modified:
9 years, 11 months ago

Reviewers:
rsc, 0intro

CC:
rsc, 0intro, golang-codereviews

Visibility:
Public.

Description

cmd/objdump: fix dissasembly of Plan 9 object files Ignore symbols that aren't text, data, or bss since they cause problems when dissassembling instructions with small immediate values. Before: build.go:142 0x10ee 83ec50 SUBL $text/template/parse.autotmp_1293(SB), SP After: build.go:142 0x10ee 83ec50 SUBL $0x50, SP Fixes issue 7947.

Patch Set 1 #

Patch Set 2 : diff -r 962157789bb0 https://code.google.com/p/go #

Patch Set 3 : diff -r 962157789bb0 https://code.google.com/p/go #

Patch Set 4 : diff -r 962157789bb0 https://code.google.com/p/go #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -4 lines)			Patch
	M	src/cmd/objdump/objdump_test.go	View	1 2 3	1 chunk	+0 lines, -4 lines	0 comments	Download
	M	src/cmd/objdump/plan9obj.go	View	1	2 chunks	+15 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

ality

Hello rsc@golang.org (cc: 0intro@gmail.com, golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

9 years, 11 months ago (2014-05-21 12:57:18 UTC) #1

ality

Hello rsc@golang.org (cc: 0intro@gmail.com, golang-codereviews@googlegroups.com), Please take another look.

9 years, 11 months ago (2014-05-21 13:08:42 UTC) #2

0intro

9 years, 11 months ago (2014-05-21 21:25:06 UTC) #5

*** Submitted as https://code.google.com/p/go/source/detail?r=5012df7fac58 ***

cmd/objdump: fix dissasembly of Plan 9 object files

Ignore symbols that aren't text, data, or bss since they cause
problems when dissassembling instructions with small immediate
values.

Before:
        build.go:142    0x10ee  83ec50      SUBL
$text/template/parse.autotmp_1293(SB), SP

After:
        build.go:142    0x10ee  83ec50      SUBL $0x50, SP

Fixes issue 7947.

LGTM=rsc
R=rsc, 0intro
CC=golang-codereviews
https://codereview.appspot.com/93520045

Committer: David du Colombier <0intro@gmail.com>

Expand All Messages | Collapse All Messages