Issue 93320043: encoding/xml: track, use default tag ns in Encoder

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 93320043: encoding/xml: track, use default tag ns in Encoder

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 11 months ago by rsc

Modified:
9 years, 11 months ago

Reviewers:
anacrolix

CC:
rsc

Visibility:
Public.

Description

encoding/xml: track, use default tag ns in Encoder Fixes issue 7113.

Patch Set 1 #

Patch Set 2 : diff -r 2fb7165d5fdc https://code.google.com/p/go/ #

Patch Set 3 : diff -r 2fb7165d5fdc https://code.google.com/p/go/ #

Total comments: 1

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+110 lines, -20 lines)			Patch
M	src/pkg/encoding/xml/marshal.go	View	1	11 chunks	+38 lines, -14 lines	1 comment	Download
M	src/pkg/encoding/xml/marshal_test.go	View	1	1 chunk	+62 lines, -0 lines	0 comments	Download
M	src/pkg/encoding/xml/typeinfo.go	View	1	3 chunks	+10 lines, -6 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

anacrolix

9 years, 11 months ago (2014-05-13 23:00:23 UTC) #1

I think this should be submitted as soon as 1.3 is branched, as there may be
downstream stuff relying on the old behaviour.

https://codereview.appspot.com/93320043/diff/40001/src/pkg/encoding/xml/marsh...
File src/pkg/encoding/xml/marshal.go (right):

https://codereview.appspot.com/93320043/diff/40001/src/pkg/encoding/xml/marsh...
src/pkg/encoding/xml/marshal.go:326: if strings.HasPrefix(prefix, "=ns=") {
Is this some kind of special value?

Expand All Messages | Collapse All Messages