|
|
DescriptionImprove source build support on darwin.
Attempting to set the maximum number of open file descriptors causes all.bash
runs to fail. Ensuring true returns allows the script to run.
Patch Set 1 #Patch Set 2 : diff -r 8f1fb6b6f141 https://code.google.com/p/go #Patch Set 3 : diff -r 8f1fb6b6f141 https://code.google.com/p/go #
Total comments: 2
Patch Set 4 : diff -r 8f1fb6b6f141 https://code.google.com/p/go #MessagesTotal messages: 20
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
Sign in to reply to this message.
What is the failure mode? What version of OS X are you running? I don't see any failures on the Darwin builders at http://build.golang.org/ .
Sign in to reply to this message.
On May 14, 2013, at 6:44 AM, iant@golang.org wrote: > What is the failure mode? What version of OS X are you running? The latest version of 10.8, but I've tested on 10.7 as well. > > I don't see any failures on the Darwin builders at > http://build.golang.org/ . > > https://codereview.appspot.com/9324044/ I have not been able to run src/all.bash on any OS X machine. They all fail when attempting to set the invalid ulimit value.
Sign in to reply to this message.
We have 10.6 and 10.7 darwin builders, the -race builder is 10.7. I'd like to be able to reproduce the failure before apply a fix. On Wed, May 15, 2013 at 2:08 AM, Mark Turner <mark@amerine.net> wrote: > On May 14, 2013, at 6:44 AM, iant@golang.org wrote: > >> What is the failure mode? What version of OS X are you running? > > The latest version of 10.8, but I've tested on 10.7 as well. > >> >> I don't see any failures on the Darwin builders at >> http://build.golang.org/ . >> >> https://codereview.appspot.com/9324044/ > > I have not been able to run src/all.bash on any OS X machine. They all fail when attempting to set the invalid ulimit value. > > -- > > --- > You received this message because you are subscribed to the Google Groups "golang-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com. > For more options, visit https://groups.google.com/groups/opt_out. > >
Sign in to reply to this message.
On Tue, May 14, 2013 at 12:30 PM, Dave Cheney <dave@cheney.net> wrote: > We have 10.6 and 10.7 darwin builders, the -race builder is 10.7. I'd > like to be able to reproduce the failure before apply a fix. > > Where can I see what the scripts/makefiles/etc that the builders are using? Are they just running src/all.bash?
Sign in to reply to this message.
The code for the builders is in $GOROOT/misc/dashboard/builder. They all run ./all.{bash,bat} (unless their build key ends in -race, in which case they run ./race.{bash,bat} On Wed, May 15, 2013 at 6:00 AM, Mark Turner <mark@amerine.net> wrote: > On Tue, May 14, 2013 at 12:30 PM, Dave Cheney <dave@cheney.net> wrote: >> >> We have 10.6 and 10.7 darwin builders, the -race builder is 10.7. I'd >> like to be able to reproduce the failure before apply a fix. >> > > Where can I see what the scripts/makefiles/etc that the builders are using? > Are they just running src/all.bash?
Sign in to reply to this message.
On 2013/05/14 20:06:01, dfc wrote: > The code for the builders is in $GOROOT/misc/dashboard/builder. They > all run ./all.{bash,bat} (unless their build key ends in -race, in > which case they run ./race.{bash,bat} Thanks Dave. I'm not sure what else to test. Here is the error that stops all.bash from completing: `run.bash: line 20: ulimit: open files: cannot modify limit: Invalid argument` That line in run.bash is specifically is trying to set the open file descriptors limit which results in an error (non-zero exit status) on all OS X 10.7,8 machines I have access to.
Sign in to reply to this message.
On Wed, May 15, 2013 at 4:35 AM, <mark@amerine.net> wrote: > `run.bash: line 20: ulimit: open files: cannot modify limit: Invalid > argument` > > That line in run.bash is specifically is trying to set the open file > descriptors limit which results in an error (non-zero exit status) on > all OS X 10.7,8 machines I have access to. > what does "ulimit -n -H" say on your system? what locale are you using? perhaps it's not english?
Sign in to reply to this message.
On 2013/05/14 20:57:52, minux wrote: > what does "ulimit -n -H" say on your system? > what locale are you using? perhaps it's not english? ~ ⮀ ulimit -n -H 32768 Specifically that is set in /etc/launchd.conf (the "proper" place to set and persist the file discriptor limit since 10.7 according to Apple). The locale in the shells is en_US. Here the output of locale: ~ ⮀ locale LANG="en_US.UTF-8" LC_COLLATE="en_US.UTF-8" LC_CTYPE="en_US.UTF-8" LC_MESSAGES="en_US.UTF-8" LC_MONETARY="en_US.UTF-8" LC_NUMERIC="en_US.UTF-8" LC_TIME="en_US.UTF-8" LC_ALL=
Sign in to reply to this message.
ping. I do not see what this CL fixes. None of our builders are broken without this change.
Sign in to reply to this message.
On 2013/05/22 01:21:13, dfc wrote: > ping. > > I do not see what this CL fixes. None of our builders are broken without this > change. dfc, I'm forced to agree with you considering it only appears to be my systems that fail to build.
Sign in to reply to this message.
Given how many people on the Go team use darwin, I'm confident this isn't a widespread issue. On Wed, May 22, 2013 at 11:46 AM, <mark@amerine.net> wrote: > On 2013/05/22 01:21:13, dfc wrote: >> >> ping. > > >> I do not see what this CL fixes. None of our builders are broken > > without this >> >> change. > > > dfc, I'm forced to agree with you considering it only appears to be my > systems that fail to build. > > https://codereview.appspot.com/9324044/
Sign in to reply to this message.
Message was sent while issue was closed.
On 2013/05/22 01:47:32, dfc wrote: > Given how many people on the Go team use darwin, I'm confident this > isn't a widespread issue. I tracked the problem down. On a fresh OS X 10.8 machine. I made a single configuration change. I set the soft and hard file descriptor limits set to 16384 and 32768 respectively, through /etc/launchd.conf (example: https://gist.github.com/amerine/f00b989ea1226bd68b77), I can cause all.bash to fail every time. When the hard limit is set in /etc/launchd.conf, and the script attempts to set it higher, it will fail.
Sign in to reply to this message.
Message was sent while issue was closed.
https://codereview.appspot.com/9324044/diff/4001/src/run.bash File src/run.bash (right): https://codereview.appspot.com/9324044/diff/4001/src/run.bash#newcode21 src/run.bash:21: ([ "$(ulimit -H -n)" == "unlimited" ] || ulimit -S -n $(ulimit -H -n)) how about this: [ "$(ulimit -H -n)" == "unlimited" ] || ulimit -S -n $(ulimit -H -n) || true [ "$(ulimit -H -d)" == "unlimited" ] || ulimit -S -d $(ulimit -H -d) || true
Sign in to reply to this message.
https://codereview.appspot.com/9324044/diff/4001/src/run.bash File src/run.bash (right): https://codereview.appspot.com/9324044/diff/4001/src/run.bash#newcode21 src/run.bash:21: ([ "$(ulimit -H -n)" == "unlimited" ] || ulimit -S -n $(ulimit -H -n)) On 2013/05/22 16:41:27, minux wrote: > how about this: > [ "$(ulimit -H -n)" == "unlimited" ] || ulimit -S -n $(ulimit -H -n) || true > [ "$(ulimit -H -d)" == "unlimited" ] || ulimit -S -d $(ulimit -H -d) || true This also works. And I like it better.
Sign in to reply to this message.
R=close
Sign in to reply to this message.
I've seen this error on Mac OS X 10.9.1
Sign in to reply to this message.
On 2014/02/20 20:28:31, tim.olsen_10gen.com wrote: > I've seen this error on Mac OS X 10.9.1 Yes, I can replicate as well. As I mentioned back in May, a system with the hard and soft limits set in /etc/launchd.conf can cause go to fail building on Darwin.
Sign in to reply to this message.
Tim, could you please distill this conversation into an issue, golang.org/issue/new. As far as I am aware, Go builds fine from source on many darwin machines without any tweaking of the ulimit tunables. On Fri, Feb 21, 2014 at 11:14 AM, <mark@amerine.net> wrote: > On 2014/02/20 20:28:31, tim.olsen_10gen.com wrote: > >> I've seen this error on Mac OS X 10.9.1 >> > > Yes, I can replicate as well. As I mentioned back in May, a system with > the hard and soft limits set in /etc/launchd.conf can cause go to fail > building on Darwin. > > https://codereview.appspot.com/9324044/ >
Sign in to reply to this message.
New issue created: https://code.google.com/p/go/issues/detail?id=7381 Tim On Thu, Feb 20, 2014 at 7:16 PM, Dave Cheney <dave@cheney.net> wrote: > Tim, could you please distill this conversation into an issue, > golang.org/issue/new. As far as I am aware, Go builds fine from source on > many darwin machines without any tweaking of the ulimit tunables. > > > On Fri, Feb 21, 2014 at 11:14 AM, <mark@amerine.net> wrote: > >> On 2014/02/20 20:28:31, tim.olsen_10gen.com wrote: >> >>> I've seen this error on Mac OS X 10.9.1 >>> >> >> Yes, I can replicate as well. As I mentioned back in May, a system with >> the hard and soft limits set in /etc/launchd.conf can cause go to fail >> building on Darwin. >> >> https://codereview.appspot.com/9324044/ >> > >
Sign in to reply to this message.
|