code review 9322043: net: make LookupCNAME querying CNAME type

net: make LookupCNAME querying CNAME type

POSIX getaddrinfo is designed for resolving DNS names but not
designed for skimming off various DNS records. Thus querying
CNAME with A or quad-A type will cause returning EAI_NONAME on
getaddrinfo. This CL replaces use of getaddrinfo with use of
net package embedded querier to prevent such error.

Fixes issue 5038.

[mikio, 2013-05-13 22:06:03]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[mikio, 2013-05-20 10:02:27]

ping

[bradfitz, 2013-05-20 18:00:07]

No test?

Would it help if I created a CNAME under golang.org for the test to hit?



On Mon, May 20, 2013 at 3:02 AM, <mikioh.mikioh@gmail.com> wrote:

> ping
>
>
https://codereview.appspot.**com/9322043/<https://codereview.appspot.com/9322...
>
>
> --
>
> ---You received this message because you are subscribed to the Google
> Groups "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to
golang-dev+unsubscribe@**googlegroups.com<golang-dev%2Bunsubscribe@googlegrou...
> .
> For more options, visit
https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/o...
> .
>
>
>

[rsc, 2013-05-20 18:54:13]

NOT LGTM

The whole point of the cgo stuff is to avoid using the pure Go DNS code, for
systems where it does not work (such as OS X, behind a firewall).

[mikio, 2013-05-22 14:05:32]

On Tue, May 21, 2013 at 3:54 AM,  <rsc@golang.org> wrote:

> The whole point of the cgo stuff is to avoid using the pure Go DNS code,
> for systems where it does not work (such as OS X, behind a firewall).

Fine. So shall we change the status of issue 5038 to unfortunate?

[mikio, 2013-05-30 00:29:48]

Russ?

>> The whole point of the cgo stuff is to avoid using the pure Go DNS code,
>> for systems where it does not work (such as OS X, behind a firewall).
>
> Fine. So shall we change the status of issue 5038 to unfortunate?

[mikio, 2013-06-08 09:06:23]

*** Abandoned ***