Issue 93200043: code review 93200043: math/cmplx: specify which square root Sqrt returns

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 93200043: code review 93200043: math/cmplx: specify which square root Sqrt returns (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 12 months ago by rsc

Modified:
9 years, 12 months ago

Reviewers:
bradfitz

CC:
golang-codereviews, bradfitz

Visibility:
Public.

Description

math/cmplx: specify which square root Sqrt returns Fixes issue 7851.

Patch Set 2 : diff -r 8f49b5cc8196 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 8f49b5cc8196 https://code.google.com/p/go/ #

Total comments: 2

Patch Set 4 : diff -r be19ef9bd7b3 https://code.google.com/p/go/ #

Created: 9 years, 12 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	src/pkg/math/cmplx/sqrt.go	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

rsc

Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/

9 years, 12 months ago (2014-05-09 18:39:22 UTC) #1

bradfitz

https://codereview.appspot.com/93200043/diff/40001/src/pkg/math/cmplx/sqrt.go File src/pkg/math/cmplx/sqrt.go (right): https://codereview.appspot.com/93200043/diff/40001/src/pkg/math/cmplx/sqrt.go#newcode57 src/pkg/math/cmplx/sqrt.go:57: // The result r is chosen so that real(r) ...

9 years, 12 months ago (2014-05-09 18:47:34 UTC) #2

rsc

9 years, 12 months ago (2014-05-09 19:42:11 UTC) #3

bradfitz

LGTM On May 9, 2014 12:42 PM, <rsc@golang.org> wrote: > > https://codereview.appspot.com/93200043/diff/40001/src/ > pkg/math/cmplx/sqrt.go > ...

9 years, 12 months ago (2014-05-09 19:50:45 UTC) #4

rsc

9 years, 12 months ago (2014-05-09 20:04:10 UTC) #5

*** Submitted as https://code.google.com/p/go/source/detail?r=98ce53519eaa ***

math/cmplx: specify which square root Sqrt returns

Fixes issue 7851.

LGTM=bradfitz
R=golang-codereviews, bradfitz
CC=golang-codereviews
https://codereview.appspot.com/93200043

Expand All Messages | Collapse All Messages