Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(877)

Issue 9304044: code review 9304044: [release-branch.go1.1] runtime: fix crash in select (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 10 months ago by adg
Modified:
10 years, 10 months ago
Reviewers:
CC:
golang-dev, r
Visibility:
Public.

Description

[release-branch.go1.1] runtime: fix crash in select ««« CL 9311043 / 53bc96b4c0c7 runtime: fix crash in select runtime.park() can access freed select descriptor due to a racing free in another thread. See the comment for details. Slightly modified version of dvyukov's CL 9259045. No test yet. Before this CL, the test described in issue 5422 would fail about every 40 times for me. With this CL, I ran the test 5900 times with no failures. Fixes issue 5422. R=golang-dev, r CC=golang-dev https://codereview.appspot.com/9311043 »»»

Patch Set 1 #

Patch Set 2 : diff -r ddfa83a0673f https://code.google.com/p/go #

Patch Set 3 : diff -r ddfa83a0673f https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -9 lines) Patch
M src/pkg/runtime/chan.c View 1 1 chunk +20 lines, -9 lines 0 comments Download

Messages

Total messages: 3
adg
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
10 years, 10 months ago (2013-05-08 23:02:20 UTC) #1
r
LGTM
10 years, 10 months ago (2013-05-08 23:02:52 UTC) #2
adg
10 years, 10 months ago (2013-05-08 23:03:03 UTC) #3
*** Submitted as https://code.google.com/p/go/source/detail?r=15e4e4cfe699 ***

[release-branch.go1.1] runtime: fix crash in select

««« CL 9311043 / 53bc96b4c0c7
runtime: fix crash in select
runtime.park() can access freed select descriptor
due to a racing free in another thread.
See the comment for details.

Slightly modified version of dvyukov's CL 9259045.

No test yet.  Before this CL, the test described in issue 5422
would fail about every 40 times for me.  With this CL, I ran
the test 5900 times with no failures.

Fixes issue 5422.

R=golang-dev, r
CC=golang-dev
https://codereview.appspot.com/9311043
»»»

R=golang-dev, r
CC=golang-dev
https://codereview.appspot.com/9304044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b